TDP Activity Search: Mobile customization #6427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@karenkitchens FYI, I merged the main branch into this PR so that our dev preview deployment would hopefully complete successfully. |
- Moves logic to own module - Adds option to the "expandable" template - Makes the search module a better team player by not initializing itself and instead allowing the index module to do this.
Formalize logic into feature of the template organism
|
@Scotchester FYI we've reworked this a bit and added a test. |
Scotchester
reviewed
May 12, 2021
| * so some elements won't be expanded by default. | ||
| */ | ||
| function beforeExpandableTransitionInit() { | ||
| document.querySelectorAll( '.' + MOBILE_COLLAPSED_CLASS ).forEach( el => { |
There was a problem hiding this comment.
I think this line is breaking the functionality of the filters in IE 11. None of the faceting works as it used to, and I see this error in the console:
Object doesn't support property or method 'forEach'
There was a problem hiding this comment.
(Affecting desktop widths, just to be clear.)
There was a problem hiding this comment.
@Scotchester I'll look into this right away. Is IE11 the baseline or (gulp) earlier versions?
There was a problem hiding this comment.
Thanks, Steve! For JS-required functionality like this, we only need to support IE 11.
mrclay
reviewed
May 13, 2021
cfgov/unprocessed/apps/teachers-digital-platform/js/expandable-mobile.js
Outdated
Show resolved
Hide resolved
Scotchester
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TDP activity search need to be customized since the desktop version of search had too many options. This will help folks move through the search more effectively when on mobile
Additions
Added mobile classes to html
Added a rule for changing mobile facets
How to test this PR
Notes and todos
Need to move the JS rule to somewhere more appropriate
Checklist
Front-end testing
Browser testing
Visually tested in the following supported browsers:
Accessibility
Other