Remove broken and deprecated CFGOVPage unit test #8461
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unit test was failing for me with certain invocations of Python unit tests, for example:
This fails due to a RecursionError in Django's settings code, whereas running those tests in reverse passed:
Digging into this, the problem is that this test patches the Python
super()
call which has all sorts of potential side effects. In this case, it was breaking something about how Django settings are cached the first time they are accessed.As it turns out, this test can be removed - it was created at a time when our
CFGOVPage.serve()
method was sometimes invoked via AJAX, which is no longer the case.Notes and todos
We have a few other tests that also patch
builtins.super()
in this way. These should also be changed to avoid this approach, as it's a very broad brush with all sorts of unpredictable side effects.Checklist