Modify Python tests to avoid patching super() #8462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Python unit tests for FilterableListForm currently patch the "builtins.super" function which can break unit tests when run in a reverse or unpredictable order. This commit updates those tests to avoid the need to patch super while still continuing to test the same functionality.
wpears
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Python unit tests for FilterableListForm currently patch the
builtins.superfunction which can break unit tests when run in a reverse or unpredictable order.This PR updates those tests to avoid the need to patch super while still continuing to test the same functionality. I also removed an unused
set_field_html_namemethod whose only use was removed in 2019 in 934a397.How to test this PR
All tests continue to pass with the same coverage (actually slightly increased due to removal of unused code).
Notes and todos
This is a followup to #8461 which removed the only other patching of
builtins.superin the codebase.Checklist