Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Button] [Pagination] Text not centered, make icon hidden to screen readers #342

Closed
shindigira opened this issue May 9, 2024 · 0 comments · Fixed by #343
Closed

[Button] [Pagination] Text not centered, make icon hidden to screen readers #342

shindigira opened this issue May 9, 2024 · 0 comments · Fixed by #343

Comments

@shindigira
Copy link
Contributor

shindigira commented May 9, 2024 •
edited
Loading

Error seen in SBL implementation
Screenshot 2024-05-09 at 1 42 01 PM
@shindigira shindigira mentioned this issue May 9, 2024
Closed
@shindigira shindigira changed the title [Button] [Pagination] Text not centered [Button] [Pagination] Text not centered, make icon hidden to screen readers May 10, 2024
@shindigira shindigira mentioned this issue May 10, 2024
Merged
shindigira added a commit that referenced this issue May 13, 2024
@shindigira @anselmbradford
style(Pagination): Button icons hidden & Button content centered (#343)
e5e11fd 
closes #342 

## Note
- Includes fixes from
#337 to pass the Netlify
build tests

## Changes
- accessibility(pagination): button icons enable isPresentational to be
ignored
- styling(pagination): button content is flex-centered.

## Screenshot
<img width="955" alt="Screenshot 2024-05-09 at 6 15 14 PM"
src="https://github.com/cfpb/design-system-react/assets/13324863/e0159f7d-67cd-421c-b284-d319c7143359">

---------

Co-authored-by: Ans <git@anselmbradford.com>
Co-authored-by: Ans <anselmbradford@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(Pagination): Button icons hidden & Button content centered cfpb/design-system-react
1 participant
@shindigira