Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Pagination): Button icons hidden & Button content centered #343

Merged
merged 12 commits into from
May 13, 2024

Conversation

shindigira
Copy link
Contributor

@shindigira shindigira commented May 10, 2024

closes #342

Note

Changes

  • accessibility(pagination): button icons enable isPresentational to be ignored
  • styling(pagination): button content is flex-centered.

Screenshot

Screenshot 2024-05-09 at 6 15 14 PM

Copy link

netlify bot commented May 10, 2024

Deploy Preview for cfpb-design-system-react ready!

Name Link
🔨 Latest commit 03adbc3
🔍 Latest deploy log https://app.netlify.com/sites/cfpb-design-system-react/deploys/664285f388c0dd000800499d
😎 Deploy Preview https://deploy-preview-343--cfpb-design-system-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shindigira shindigira changed the title Pagination - Button icons hidden & Button content centered style(Pagination): Button icons hidden & Button content centered May 10, 2024
@shindigira shindigira added enhancement New feature or request and removed enhancement New feature or request labels May 10, 2024
Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible 👍🏾

Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to backtrack, but this setting seems a bit questionable.

Looking at the Changeset in Chromatic, it seems that every story's screenshot is getting regenerated - whether or not there are actual changes to the UI.

Was there something that you saw previously in Chromatic that sparked you to add this flag?

@shindigira
Copy link
Contributor Author

Sorry to backtrack, but this setting seems a bit questionable.

Looking at the Changeset in Chromatic, it seems that every story's screenshot is getting regenerated - whether or not there are actual changes to the UI.

Was there something that you saw previously in Chromatic that sparked you to add this flag?

The build tests weren't passing so I pulled in ans's update; it fixed it but then for some reason the chromatic snapshots are being compared.

I reverted the autoAcceptChanges setting since it doesn't prevent the screenshots from being generated; I don't know why every story's screenshot is getting generated.

Copy link
Contributor

@meissadia meissadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve in Chromatic but will approve here and hopefully that's enough to move forward?

@shindigira shindigira merged commit e5e11fd into main May 13, 2024
9 of 10 checks passed
@shindigira shindigira deleted the pagination-buttons-centering branch May 13, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Button] [Pagination] Text not centered, make icon hidden to screen readers
3 participants