fix: [Table] Pagination input label's 'for' property needs to align with the input id #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cfpb-design-system-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- Uniquely identify pagination <input> elements - Correctly associate pagination <input> labels with the input id
shindigira
requested changes
May 25, 2024
meissadia
force-pushed
the
table__pagination-input__label-for
branch
from
5956806
to
281e57e
Compare
shindigira
previously requested changes
May 30, 2024
meissadia
dismissed
shindigira’s stale review
Provided context that I believe addresses the expressed concern.
meissadia
added a commit
to cfpb/sbl-frontend
that referenced
this pull request
Jun 6, 2024
Close #568 ## Changes - [Accessibility] Fix labelling issue in DSR Table/Pagination - Dependent upon cfpb/design-system-react#356 - `Upload a new file` now a secondary button ([should be a link but I couldn't get the styling overrides to play nice with one another](#575)) - Update primary button label: `Download Report (CSV)` - Remove green header border on Filing pages ## Screenshots |Change|Screenshot| |---|---| |Button label (Warnings)|<img width="739" alt="Screenshot 2024-05-31 at 4 04 11 PM" src="https://github.com/cfpb/sbl-frontend/assets/2592907/be87effb-1174-446a-89e8-44433b0a1c71">| |Button label (Errors)|<img width="767" alt="Screenshot 2024-05-31 at 4 09 02 PM" src="https://github.com/cfpb/sbl-frontend/assets/2592907/a5b4b6d1-f4c7-4be5-8ada-5f9d596026ea">| |Remove green header border on filing|<img width="1230" alt="Screenshot 2024-06-03 at 9 54 54 AM" src="https://github.com/cfpb/sbl-frontend/assets/2592907/e404f67b-3ff6-46a6-825f-fab60e574260">| |Accessibility for pagination: input's `for` label aligns with table id|<img width="974" alt="Screenshot 2024-06-03 at 9 53 03 AM" src="https://github.com/cfpb/sbl-frontend/assets/2592907/35732b11-95ac-4627-a12e-00331896848b">| --------- Co-authored-by: Bill Himmelsbach <whimmels@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessibility improvement
Changes
tableIdto uniquely identify and label Pagination's input elementHow to test this PR
Element nested in <label> but label[for=m-pagination_current-page] does not match element [id=m-pagination_current-page-defaultScreenshots