Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Warnings/Errors] Design and accessibility improvements #576

Merged
merged 21 commits into from
Jun 6, 2024

Conversation

meissadia
Copy link
Collaborator

@meissadia meissadia commented May 23, 2024

Close #568

Changes

Screenshots

Change Screenshot
Button label (Warnings) Screenshot 2024-05-31 at 4 04 11 PM
Button label (Errors) Screenshot 2024-05-31 at 4 09 02 PM
Remove green header border on filing Screenshot 2024-06-03 at 9 54 54 AM
Accessibility for pagination: input's for label aligns with table id Screenshot 2024-06-03 at 9 53 03 AM

@meissadia meissadia changed the title task: FilingFieldLinks - make Upload a secondary button [Warnings] Design and accessibility improvements May 24, 2024
@meissadia meissadia marked this pull request as ready for review May 31, 2024 22:07
@meissadia meissadia changed the title [Warnings] Design and accessibility improvements [Warnings/Errors] Design and accessibility improvements May 31, 2024
Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meissadia, when you run this with ANDI, do you still see errors with the label?

@billhimmelsbach
Copy link
Contributor

If you end up needing it @meissadia, here's a PR with the latest DSR that can be merged into your branch:
#632

@meissadia
Copy link
Collaborator Author

If you end up needing it @meissadia, here's a PR with the latest DSR that can be merged into your branch: #632

@billhimmelsbach Many thanks for this! Don't know why I couldn't get the dependency to update...

Copy link
Contributor

@billhimmelsbach billhimmelsbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for continuing to update this one!

@meissadia meissadia merged commit 46b3fea into main Jun 6, 2024
4 checks passed
@meissadia meissadia deleted the 568__design-review__warnings branch June 6, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design Review] Warnings
2 participants