Add gulp option #103
Merged
Add gulp option #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -14,6 +14,7 @@ | |||
| }, | |||
| "license": "<%= props.license %>", | |||
| "dependencies": { <% for(var i=0; i<components.length; i++) { %> | |||
| "<%= components[i].name %>": "<%= components[i].ver%>"<% if (i < components.length - 1) { %>,<% } %><% } %> | |||
| "<%= components[i].name %>": "<%= components[i].ver%>"<% if (i < components.length - 1) { %>,<% } %><% } %>, | |||
| "jquery.easing": "~1.3.0" | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Whoops, good catch, I thought I'd removed everything browserify related.
|
@jimmynotjim This is really exciting! Everything builds fine for me. I filed a PR against your fork with some smoke tests. |
|
Merged smoke tests and looking good. |
|
👍 S'all good here. |
|
Let me test this just once more before we merge it. |
| scripts: { | ||
| src: [ | ||
| loc.lib + '/jquery/dist/jquery.js', | ||
| loc.lib + '/jquery.easing/js/jquery.easing.js', |
There was a problem hiding this comment.
Remove easing here if removed in #103 (comment)
There was a problem hiding this comment.
Oh, now I'm not sure, cause it was in the Gruntfile
- Generator asks which build tool you prefer - Installs Grunt or Gulp deps and template files based on your answer
|
Good-to-go? Let's hope so. Mergin'. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to start a project with Gulp instead of Grunt. It uses pretty much the same exact setup, just with a few tweaks.
Additions
/gulpdirectoryRemovals
Changes
askForBuildTooloption during generation to allow user to choose their build tool/gruntdirectoryTesting
git checkout gulp option && npm linkmk test-project && cd_yo cfmaking sure to choose Gulp as your build toolgulp buildReview
Screenshots
## Todos - None ## Checklist - [ ] Changes are limited to a single goal (no scope creep) - [ ] Code can be automatically merged (no conflicts) - [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end) - [ ] Passes all existing automated tests - [ ] New functions include new tests - [ ] New functions are documented (with a description, list of inputs, and expected output) - [ ] Placeholder code is flagged - [ ] Visually tested in supported browsers and devices - [ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)