-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gulp option #103
Add gulp option #103
Conversation
@@ -14,6 +14,7 @@ | |||
}, | |||
"license": "<%= props.license %>", | |||
"dependencies": { <% for(var i=0; i<components.length; i++) { %> | |||
"<%= components[i].name %>": "<%= components[i].ver%>"<% if (i < components.length - 1) { %>,<% } %><% } %> | |||
"<%= components[i].name %>": "<%= components[i].ver%>"<% if (i < components.length - 1) { %>,<% } %><% } %>, | |||
"jquery.easing": "~1.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was jquery.easing added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoops, good catch, I thought I'd removed everything browserify related.
@jimmynotjim This is really exciting! Everything builds fine for me. I filed a PR against your fork with some smoke tests. |
Merged smoke tests and looking good. |
👍 S'all good here. |
Let me test this just once more before we merge it. |
scripts: { | ||
src: [ | ||
loc.lib + '/jquery/dist/jquery.js', | ||
loc.lib + '/jquery.easing/js/jquery.easing.js', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove easing here if removed in #103 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, now I'm not sure, cause it was in the Gruntfile
- Generator asks which build tool you prefer - Installs Grunt or Gulp deps and template files based on your answer
Good-to-go? Let's hope so. Mergin'. |
This PR adds the option to start a project with Gulp instead of Grunt. It uses pretty much the same exact setup, just with a few tweaks.
Additions
/gulp
directoryRemovals
Changes
askForBuildTool
option during generation to allow user to choose their build tool/grunt
directoryTesting
git checkout gulp option && npm link
mk test-project && cd_
yo cf
making sure to choose Gulp as your build toolgulp build
Review
Screenshots
![screen shot 2015-10-06 at 8 28 40 pm](https://cloud.githubusercontent.com/assets/1280430/10326416/d920c55c-6c68-11e5-85ea-cfe472b4766c.png)
## Todos - None ## Checklist - [ ] Changes are limited to a single goal (no scope creep) - [ ] Code can be automatically merged (no conflicts) - [ ] Code follows the standards laid out in the [front end playbook](https://github.com/cfpb/front-end) - [ ] Passes all existing automated tests - [ ] New functions include new tests - [ ] New functions are documented (with a description, list of inputs, and expected output) - [ ] Placeholder code is flagged - [ ] Visually tested in supported browsers and devices - [ ] Project documentation has been updated (including the "Unreleased" section of the CHANGELOG)