Wizard back navigation #347
Conversation
| @@ -70,7 +70,7 @@ | |||
| } | |||
| } | |||
|
|
|||
| a { outline: 0; } | |||
| a { outline: 0; cursor: pointer; } | |||
There was a problem hiding this comment.
By default, anchors should already get cursor: pointer. What problem is this trying to solve?
There was a problem hiding this comment.
An anchor without an href isn't getting a pointer. Which leads me to think I should probably change the element to a span.
There was a problem hiding this comment.
Changed in 415a855
| @@ -2,8 +2,7 @@ | |||
| <ol> | |||
| <li ng-repeat="step in steps" class="step {{step.stepClass}}"> | |||
| <span class="{{step.badgeClass}}">{{step.badgeText}}</span> | |||
| <a class="step-title" ng-if="step.isComplete()" ng-href="/#/{{step.view}}">{{step.title}}</a> | |||
| <span class="step-title" ng-if="!step.isComplete()">{{step.title}}</span> | |||
| <span class="step-title" ng-click="setFocused(step)">{{step.title}}</span> | |||
There was a problem hiding this comment.
While you can add an ng-click to a span, for accessibility we need to be presenting the user with an anchor. There are ways around that to continue using a span, but there's not reason why we can't optionally display the anchor here.
There was a problem hiding this comment.
How about now? Switched back to an anchor in c0e7173.
|
This has been reverted manually. Was merged to master instead of milestone10. |
For #320.
If you select a previously completed step, it is 'focused' and colored the same orange as when hovering over a step. The currently active step remains the blueish color when it is focused.