This repository has been archived by the owner on Jun 4, 2021. It is now read-only.
Add handling for leap day birthdays #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
higs4281
approved these changes
May 14, 2018
Scotchester
reviewed
May 14, 2018
|
Oh, please update the version number in |
We've been getting a ValueError for day out of range errors when a leap day birthday is entered in a non-leap year. This handles that error.
Scotchester
force-pushed
the
fix-leap-bday-error
branch
from
1904aa1
to
60997dc
Compare
|
Went down a Snyk rabbit hole, and also discovered that this branch was a ways behind master, so I updated a bunch of stuff and force-pushed it. |
Scotchester
approved these changes
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been getting a ValueError for day out of range errors when a leap day birthday is entered in a non-leap year. This handles that error.
Testing