Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

Remove support for Django 1.8 #231

Merged
merged 2 commits into from Sep 27, 2018
Merged

Remove support for Django 1.8 #231

merged 2 commits into from Sep 27, 2018

Conversation

schbetsy
Copy link
Collaborator

@schbetsy schbetsy commented Sep 26, 2018 •
edited

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code follows the standards laid out in the development playbook
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future todos are captured in comments
  • Visually tested in supported browsers and devices (see checklist below 馃憞)
  • Project documentation has been updated
  • Reviewers requested with the Reviewers tool 鉃★笍

Testing checklist

Browsers

  • Chrome
  • Firefox
  • Safari
  • Internet Explorer 8, 9, 10, and 11
  • Edge
  • iOS Safari
  • Chrome for Android

Accessibility

  • Keyboard friendly
  • Screen reader friendly

Other

  • Is useable without CSS
  • Is useable without JS
  • Flexible from small to large screens
  • No linting errors or warnings
  • JavaScript tests are passing

@coveralls
Copy link

coveralls commented Sep 26, 2018 •
edited

Coverage Status

Coverage remained the same at 99.345% when pulling 026395c on post-dj111-cleanup into 6a54049 on master.

@chosak
Copy link
Member

chosak commented Sep 27, 2018

One thing I just noticed is that the CHANGELOG.md for this repo is out of date. Should we bring it up to date either with this change, or as a separate PR?

@schbetsy
Deprecate CHANGELOG in favor of Github releases
026395c 
The changelog was a manual process that was redudant to the Github
release log. It was becoming out of date because it's easy to forget to
update it.

Before replacing the changelog with a deprecation message, I did a
review to ensure that all information from the changelog also exists in
the github release log.
@schbetsy
Copy link
Collaborator Author

Good idea. Since the CHANGELOG.md had fallen out of date anyway (in addition to my changes), I decided to emulate the cfgov-refresh changelog.

@schbetsy schbetsy merged commit 7106d1b into master Sep 27, 2018
@schbetsy schbetsy deleted the post-dj111-cleanup branch September 27, 2018 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chosak chosak chosak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@schbetsy @coveralls @chosak