Skip to content

Commit

Permalink
[Type of FI] Update page content (#543)
Browse files Browse the repository at this point in the history
Close #532

This PR has transformed into a few smaller header updates and some code
cleanup:
- Update institution (section header)
<img width="1076" alt="Screenshot 2024-05-28 at 1 54 17 PM"
src="https://github.com/cfpb/sbl-frontend/assets/2592907/9f8b4e7e-82be-496b-a9b6-f5f50763f632">
- Provide type of financial institution (header)

![screencapture-localhost-8899-institution-123456789TESTBANK123-type-2024-2024-05-28-13_59_27](https://github.com/cfpb/sbl-frontend/assets/2592907/72b77eaf-57cb-4079-aad3-4bc6e98c3ddf)

---------

Co-authored-by: Bill Himmelsbach <whimmels@gmail.com>
  • Loading branch information
meissadia and billhimmelsbach committed May 29, 2024
1 parent 9ace385 commit 05504da
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default function FinancialInstitutionDetailsForm({
}): JSXElement {
return (
<FinancialInstitutionDetails
heading='Review your financial institution details'
heading='Financial institution details'
data={data}
/>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,7 @@ function TypesFinancialInstitutionSection({
{...register('sbl_institution_types_other', {
value: typeOtherData?.details,
})}
helperText='You must enter a type of financial institution in the text field when
“Other” is selected. Separate multiple entries with a comma and a space.'
helperText='You must enter a type of financial institution in the text field when “Other” is selected. Separate multiple entries with a comma and a space.'
errorMessage={formErrors.sbl_institution_types_other?.message}
showError
isLast
Expand Down
7 changes: 4 additions & 3 deletions src/pages/TypesFinancialInstitutions/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { UpdateTOIFormHeaderErrors } from 'components/FormErrorHeader.data';
import FormHeaderWrapper from 'components/FormHeaderWrapper';
import FormMain from 'components/FormMain';
import FormWrapper from 'components/FormWrapper';
import { Link } from 'components/Link';
import { LoadingContent } from 'components/Loading';
import { Alert, Paragraph, TextIntroduction } from 'design-system-react';
import FilingNavButtons from 'pages/Filing/FilingApp/FilingNavButtons';
Expand All @@ -20,7 +21,7 @@ import type { UpdateTypeOfInstitutionType } from 'pages/Filing/UpdateFinancialPr
import { UpdateTypeOfInstitutionSchema } from 'pages/Filing/UpdateFinancialProfile/types';
import { scrollToElement } from 'pages/ProfileForm/ProfileFormUtils';
import { useForm } from 'react-hook-form';
import { Link, useNavigate, useParams } from 'react-router-dom';
import { useNavigate, useParams } from 'react-router-dom';
import { normalKeyLogic } from 'utils/getFormErrorKeyLogic';
import useInstitutionDetails from 'utils/useInstitutionDetails';
import { formatTypesForApi } from './TypesFinancialInstitutions.helpers';
Expand Down Expand Up @@ -111,8 +112,8 @@ function TypesFinancialInstitutions(): JSX.Element {
</CrumbTrail>
</div>
<TextIntroduction
heading='Provide your type of financial institution'
subheading='Select all applicable types of financial institutions from the list below. If the enumerated types do not appropriately describe your institution, or if you wish to add additional types, select "Other" and add your financial institution type in the text field.'
heading='Provide type of financial institution'
subheading='Select all applicable types of financial institutions from the list below. If the enumerated types do not appropriately describe your financial institution, or if you wish to add additional types, select "Other" and add your financial institution type in the text field.'
description={
<Paragraph>
You must select at least one type of financial institution to
Expand Down

0 comments on commit 05504da

Please sign in to comment.