Type of FI - Updated content
#532
Assignees
Labels
mvp
Need to be completed before MVP
Comments
This was referenced May 20, 2024
shindigira
added a commit
that referenced
this issue
May 24, 2024
…te, [All Forms] Field-Level Errors and Header Errors content pass (#566) closes #553 closes #562 closes #569 closes #532 ### Field level errors and form error header messages matching the figma's - [x] Complete Your User Profile - [x] Complete Your User Profile (No Assoc) - [x] Point of Contact - [x] Types of Financial Institutions - [x] Update your Financial Profile ## Changes - chore(Point of Contact): Removed the `-- select option --` in the states selection - refactor(formErrorHeader): changed the component (used in all forms) to be more flexible - content(formErrorHeader): made a content pass to the field level errors and header error messages ## How to Test - Test every form and every input field, select or checkbox - Compare with the figma ## Screenshots (Updated 05/23/2024) ### Note: Small content updates are present but not shown in the screenshots | Complete Your Profile | Complete Your Profile (No Assoc) | |--|--| |<img width="271" alt="Screenshot 2024-05-23 at 4 22 37 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/700cb925-04a5-4c41-80de-62557c18519a">|<img width="271" alt="Screenshot 2024-05-23 at 4 19 09 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/19354d1e-bbcc-47b0-89a3-c59439979c65">| | Point of Contact A | Point of Contact B | |--|--| |<img width="273" alt="Screenshot 2024-05-23 at 5 01 34 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/98ad9c57-94cd-4581-be7d-c951bda5d2a7">|<img width="260" alt="Screenshot 2024-05-23 at 5 06 27 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/3b2b2e24-6ef3-4d59-a6fb-337e21f88f79">| | Types of Financial Institutions A | Types of Financial Institutions B | |--|--| |<img width="478" alt="Screenshot 2024-05-23 at 4 39 34 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/40c63aa3-fe22-40f9-9712-8153aad07dd5">|<img width="481" alt="Screenshot 2024-05-23 at 4 39 49 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/42052ce4-124b-4c9f-bc3c-8e15cb5c25bb">| | Update Financial Profile A | Update Financial Profile B | Update Financial Profile C | Update Financial Profile D | |--|--|--|--| |<img width="530" alt="Screenshot 2024-05-23 at 4 03 29 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/5d1f667e-d686-4090-8001-fa4b03f743bb">|<img width="528" alt="Screenshot 2024-05-23 at 4 03 39 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/e3cea4b4-983f-43c8-80c9-21d1871b3cf5">|<img width="529" alt="Screenshot 2024-05-23 at 4 03 45 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/b146da17-7a95-49f2-938f-455bdb409947">|<img width="402" alt="Screenshot 2024-05-23 at 4 03 54 PM" src="https://github.com/cfpb/sbl-frontend/assets/13324863/b7991104-076e-4500-b35a-f69fb76967ea">|
meissadia
added a commit
that referenced
this issue
May 29, 2024
Close #532 This PR has transformed into a few smaller header updates and some code cleanup: - Update institution (section header) <img width="1076" alt="Screenshot 2024-05-28 at 1 54 17 PM" src="https://github.com/cfpb/sbl-frontend/assets/2592907/9f8b4e7e-82be-496b-a9b6-f5f50763f632"> - Provide type of financial institution (header)  --------- Co-authored-by: Bill Himmelsbach <whimmels@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: