Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update poc/ code to be compatible with python3 #201

Merged
merged 2 commits into from Jan 22, 2020
Merged

update poc/ code to be compatible with python3 #201

merged 2 commits into from Jan 22, 2020

Conversation

kwantam
Copy link
Collaborator

@kwantam kwantam commented Jan 21, 2020 •
edited

This PR updates the code to work with Python3/Sage9.

I've tested with Sage9 and with Sage8.1, and both appear to work correctly.

--

Seems good to go now. Closes #199.

@armfazh armfazh mentioned this pull request Jan 22, 2020
Merged
@armfazh
Copy link
Collaborator

armfazh commented Jan 22, 2020 •
edited

All tests pass in Sage v9. LGTM for merging

chris-wood
chris-wood approved these changes Jan 22, 2020
View reviewed changes
Copy link
Collaborator

@chris-wood chris-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kwantam! This LGTM, too.

@chris-wood chris-wood merged commit 4bde0ad into cfrg:master Jan 22, 2020
@kwantam kwantam deleted the py3 branch January 22, 2020 15:18
@chris-wood chris-wood mentioned this pull request Feb 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-wood chris-wood chris-wood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to Python 3
3 participants
@kwantam @armfazh @chris-wood