Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added proposal to caveat the server-side registration warning #437

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

stef
Copy link
Contributor

@stef stef commented Dec 5, 2023

draft proposal to settle #434

@kevinlewi
Copy link
Collaborator

kevinlewi commented Dec 9, 2023

I'm hoping to cut down on the wording and avoid referencing corporate deployments. How about the following suggested text, instead?

Some applications may require learning the client's password for enforcing password
rules. Doing so invalidates this important security property of OPAQUE and is
NOT RECOMMENDED, unless it is not possible for applications to move such checks
to the client. Note that limited checks at the server are possible to implement, e.g.,
detecting repeated passwords upon re-registrations or password change.

Note that the delta is that we are caveating the "NOT RECOMMENDED", with the phrasing "unless it is not possible for applications to move such checks to the client" without elaborating the different scenarios where that might not be possible. I hope this still captures what you are aiming for!

@stef ^

Copy link
Collaborator

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes for the above comment ^

Copy link
Collaborator

@kevinlewi kevinlewi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

But I also want to make sure that @chris-wood and @bytemare get a chance to see this before merging.

@kevinlewi kevinlewi merged commit f036cf2 into cfrg:master Dec 14, 2023
1 check failed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants