Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsys: greybus: tie log levels into kconfig #36

Closed
cfriedt opened this issue Dec 16, 2020 · 0 comments · Fixed by #38
Closed

subsys: greybus: tie log levels into kconfig #36

cfriedt opened this issue Dec 16, 2020 · 0 comments · Fixed by #38
Assignees
@cfriedt
Labels
enhancement New feature or request
Milestone
Alpha

Comments

@cfriedt
Copy link
Owner

cfriedt commented Dec 16, 2020

Currently, some greybus components use CONFIG_GREYBUS_LOG_LEVEL but others just have their log levels hard-coded.

It might not be best to use a single log level for all Greybus components (i.e. eventually they could each have their own independent Kconfig setting) but for now it's better to tie them all into a single Kconfig variable than to hard-code them.
@cfriedt cfriedt added the enhancement New feature or request label Dec 16, 2020
@cfriedt cfriedt added this to the Alpha milestone Dec 16, 2020
@cfriedt cfriedt self-assigned this Dec 16, 2020
@cfriedt cfriedt mentioned this issue Dec 16, 2020
Merged
cfriedt added a commit that referenced this issue Dec 16, 2020
@cfriedt
subsys: greybus: tie log levels into kconfig
014db32 
This change unifies logging under all of Greybus and brings
out control of the log level through Kconfig.

It might not be best to use a single log level for all Greybus
components (i.e. eventually they could each have their own
independent Kconfig setting) but for now it's better to tie them
all into a single Kconfig variable than to hard-code them.

Fixes #36

Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
cfriedt added a commit that referenced this issue Dec 16, 2020
@cfriedt
subsys: greybus: tie log levels into kconfig
be48970 
This change unifies logging under all of Greybus and brings
out control of the log level through Kconfig.

It might not be best to use a single log level for all Greybus
components (i.e. eventually they could each have their own
independent Kconfig setting) but for now it's better to tie them
all into a single Kconfig variable than to hard-code them.

Fixes #36

Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
@cfriedt cfriedt mentioned this issue Dec 17, 2020
Closed
cfriedt added a commit that referenced this issue Dec 29, 2020
@cfriedt
subsys: greybus: tie log levels into kconfig
80cac7e 
This change unifies logging under all of Greybus and brings
out control of the log level through Kconfig.

It might not be best to use a single log level for all Greybus
components (i.e. eventually they could each have their own
independent Kconfig setting) but for now it's better to tie them
all into a single Kconfig variable than to hard-code them.

Fixes #36

Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
cfriedt added a commit that referenced this issue Dec 29, 2020
@cfriedt
subsys: greybus: tie log levels into kconfig
e82f886 
This change unifies logging under all of Greybus and brings
out control of the log level through Kconfig.

It might not be best to use a single log level for all Greybus
components (i.e. eventually they could each have their own
independent Kconfig setting) but for now it's better to tie them
all into a single Kconfig variable than to hard-code them.

Fixes #36

Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cfriedt cfriedt

Labels
enhancement New feature or request
Projects
None yet
Milestone
Alpha
Development

Successfully merging a pull request may close this issue.

subsys: greybus: tie log levels into kconfig cfriedt/greybus-for-zephyr
1 participant
@cfriedt