Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: run compliance checks #57

Open
cfriedt opened this issue Dec 29, 2020 · 0 comments
Open

build: run compliance checks #57

cfriedt opened this issue Dec 29, 2020 · 0 comments
Labels
build enhancement New feature or request
Milestone
Beta

Comments

@cfriedt
Copy link
Owner

cfriedt commented Dec 29, 2020

Zephyr has some scripts that check various compliance items (the compliance items are selectable). This will catch things like missing copyright notices but it can be configured to catch virtually every issue.

It might be worth it to skip subsys/greybus/*.c but to check subsys/greybus/platform/ because much of the original NuttX code will likely not adhere to the same styles that Zephyr uses. A not necessarily obvious goal is to also leave much of the original NuttX / Greybus code intact as-is with as little change as possible.

https://github.com/zephyrproject-rtos/zephyr/blob/master/.github/workflows/compliance.yml
@cfriedt cfriedt added build enhancement New feature or request labels Dec 29, 2020
@cfriedt cfriedt added this to the Beta milestone Dec 29, 2020
@cfriedt cfriedt mentioned this issue Dec 29, 2020
Closed
cfriedt added a commit that referenced this issue Dec 29, 2020
@cfriedt
build: run compliance checks
51bf430 
This change ensures that code changes satisfy a number of
criteria before being considered for submission.

The compliance checks are similar to those in Zephyr.

Fixes #57

Signed-off-by: Christopher Friedt <chrisfriedt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build enhancement New feature or request
Projects
None yet
Milestone
Beta
Development

Successfully merging a pull request may close this issue.

build: run compliance checks cfriedt/greybus-for-zephyr
1 participant
@cfriedt