Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing Content-Type header in response. #24

Merged
merged 1 commit into from
Jul 8, 2018

Conversation

cwitte4191
Copy link

This defect was triggered by a server that replied to a request without a Content-Type header.
The response headers (as captured by wireshark) follow:

HTTP/1.1 302
Set-Cookie: JSESSIONID=E0DCDBB29FC3626D75D1B4876D4EBE86; Path=/derbytimer-0.1.4.BUILD-SNAPSHOT; HttpOnly
Location: /derbytimer-0.1.4.BUILD-SNAPSHOT/login;jsessionid=E0DCDBB29FC3626D75D1B4876D4EBE86?login_error=t
Content-Length: 0
Date: Sat, 30 Jun 2018 02:24:23 GMT

@codecov-io
Copy link

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #24   +/-   ##
======================================
  Coverage    85.8%   85.8%           
======================================
  Files           9       9           
  Lines         317     317           
======================================
  Hits          272     272           
  Misses         45      45
Impacted Files Coverage Δ
lib/src/TransFormer.dart 74.19% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48296cd...55acc93. Read the comment docs.

Copy link
Contributor

@wendux wendux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will merge it.

@wendux wendux merged commit eaf9827 into cfug:master Jul 8, 2018
AlexV525 added a commit that referenced this pull request Feb 13, 2023
* 🔥 Clean codes

* ⚡️ Make all `cancelFuture` void

* ⚡️ Make `ResponseBody.statusCode` non-nullable

* ⚡️ Return correct stack traces in the HTTP/2 adapter

* ⚡️ Improve interceptors

* ⚡️ Const `DioError`

* ⚡️ Improve the constructor of `CookieManager`

* 💚 Fix tests

* 🔥 Remove usages of `DefaultHttpClientAdapter`

* 🔥 Remove stubs

* 📝 Finish the migration guide

* 📝 Format tables in READMEs

* 🚀 Migrate new `kIsWeb`

* ⚡️ Improve how to initiate adapters

* 🎨 Consist naming

* ⚡️ Improve adapters

* 🔥 Remove empty stack traces for `DioError`

* 🥅 Improve `catchError`s

* 🔥 Remove locks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants