Add validation for baseUrl (#18)

Co-authored-by: dafinoer <dafinoer@outlook.com>
cfug · Nov 8, 2022 · 55f4529 · 55f4529
1 parent 090f18f
commit 55f4529
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/dio/lib/src/options.dart b/dio/lib/src/options.dart
@@ -100,6 +100,7 @@ class BaseOptions extends _RequestConfig with OptionsMixin {
     ListFormat? listFormat,
     this.setRequestContentTypeWhenNoPayload = false,
   })  : assert(connectTimeout == null || !connectTimeout.isNegative),
+        assert(baseUrl.isEmpty || Uri.parse(baseUrl).host.isNotEmpty),
         super(
           method: method,
           receiveTimeout: receiveTimeout,

diff --git a/dio/test/options_test.dart b/dio/test/options_test.dart
@@ -302,6 +302,21 @@ void main() {
     expect(textResponse2.data, json.encode(expectedResponseData));
   });
 
+  test('#test option invalid base url', () {
+    final opt1 = 'blob:http://localhost/xyz123';
+    final opt2 = 'https://flutterchina.club';
+    final opt3 = 'https://';
+    final opt4 = 'https://loremipsum/';
+    final opt5 = '';
+    final opt6 = 'google.com';
+    expect(Uri.parse(opt1).host.isNotEmpty, false);
+    expect(Uri.parse(opt2).host.isNotEmpty, true);
+    expect(Uri.parse(opt3).host.isNotEmpty, false);
+    expect(Uri.parse(opt4).host.isNotEmpty, true);
+    expect(Uri.parse(opt5).host.isNotEmpty, false);
+    expect(Uri.parse(opt6).host.isNotEmpty, false);
+  });
+
   test('Throws when using invalid methods', () async {
     final dio = Dio();
     void testInvalidArgumentException(String method) async {