Skip to content
This repository has been archived by the owner on Feb 13, 2023. It is now read-only.

Add validation for baseUrl #18

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Add validation for baseUrl #18

merged 2 commits into from
Nov 8, 2022

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Nov 8, 2022

Picked from cfug/dio#1583

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest develop to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I am adding
  • I have updated the documentation (if necessary)
  • I have run the tests and they pass

Pull Request Description

Just check validation for valid URL in option.baseUrl
cfug/dio#1373

dafinoer and others added 2 commits October 21, 2022 21:13
…to validate-base-url

# Conflicts:
#	dio/lib/src/options.dart
#	dio/test/options_test.dart
@AlexV525 AlexV525 merged commit 55f4529 into main Nov 8, 2022
@AlexV525 AlexV525 deleted the validate-base-url branch November 8, 2022 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants