This repository has been archived by the owner on Jul 27, 2020. It is now read-only.
Add support for services #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add (basic) support for services, to be extended later on.
balloob
reviewed
Jan 20, 2020
balloob
reviewed
Jan 20, 2020
balloob
reviewed
Jan 20, 2020
balloob
reviewed
Jan 20, 2020
apply to hass coding standards undo the file permissions
|
All fixed. No idea where the linter in Travis is angry about. Both flake8 and pylinter are happy on my setup with default PEP8 style conventions enabled. |
|
Both isort and black are not satisfied: https://travis-ci.com/cgarwood/homeassistant-zwave_mqtt/builds/145290764 Locally run For now manually run |
balloob
approved these changes
Jan 20, 2020
|
btw for Travis, you can click on "Details" and then click on "The Build" |
|
Are you on Discord? Let's connect there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add (basic) support for services, to be extended later on.
I've decided to move the services stuff into a separate file/class for code hygiene/readability reasons, in the old implementation this was all packed into the config_flow method which is horror to read/follow.