Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some bugs. #5

Closed
wants to merge 2 commits into from
Closed

Fixed some bugs. #5

wants to merge 2 commits into from

Conversation

tiwb
Copy link
Contributor

@tiwb tiwb commented Dec 25, 2012

Hi, I have been used cgdb for a while, when I moved to macosx, I found that cgdb will always not quit when using 'q' command in the gdb window after run target program. And I found the reason is that when gdb closes, both SIGCHLD is received and gdb_fd is readable. For some reason, the signal comes a little later, just after that check of tgdb->has_sigchld_recv in function tgdb_process. The result is tgdb_process will never called again.

I'm not sure this patch is the right way to fix this, It just works for me. Please fix this, in any way.

And I'm sorry that I made a mistake for the following code in cgdb/sources.c:
if (sview->curr)
sview->cur->buf.cur_line = NULL;

please change 'curr' to 'cur' when you merge, maybe check null for sview too.

@mmueller
Copy link
Member

Thanks for submitting this. It sounds like the same issue as #1. I won't be able to test it for a couple weeks, but after that I'll try to make sure a fix gets committed.

@mmueller
Copy link
Member

Ok, I was able to test these patches on MacOS and they look great. Merged them into master. Thanks tiwb!

@mmueller
Copy link
Member

tiwb, would you like your name to appear in the AUTHORS file? If so, please include your name and (optionally) email address and I'll add it.

@tiwb
Copy link
Contributor Author

tiwb commented Jan 14, 2013

Thank you mmueller, I'm Li Jia (tiwb at msn dot com) and I'm glad this patch helps. it's my pleasure.

brasko added a commit that referenced this pull request Jul 19, 2014
… quit cgdb."

This reverts commit aecc242.

This was reverted because it was believed that it fixed issue #1 and #5.

I've now properly fixed this in fix for #46.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants