Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't reload after adding to list #5541

Closed
Bananeweizen opened this issue Mar 17, 2016 · 6 comments
Closed

don't reload after adding to list #5541

Bananeweizen opened this issue Mar 17, 2016 · 6 comments
Labels
Bug Issues classified as a bug

Comments

@Bananeweizen
Copy link
Member

Detailed steps causing the problem:
  • Open cache details activity, scroll down
  • Add to list
Actual behaviour after performing these steps:

Details activity refreshes, we jump to the top of the screen

Expected behaviour after performing these steps:

No reload/refresh of the activity, but just refreshing the view containing the list names

@Bananeweizen Bananeweizen added the Bug Issues classified as a bug label Mar 17, 2016
@Lineflyer
Copy link
Member

This is a regression after #87 has been implemented, isn't it?
I do have 2016.03.15-NB (old list style) and can't reproduce.

@pstorch
Copy link
Contributor

pstorch commented Mar 20, 2016

This is the problem when no list is associated with the cache. The the isOffline() method returns false, even if the cache was saved before.
I thought about loading the "_id" column from the DB into the Cache Model class. Then we could correctly determine if the cache is in the DB or not.
What do you think?

@SammysHP
Copy link
Member

What is with caches that are in the database, but not stored? (= cached)

@Lineflyer
Copy link
Member

I just wanted to mention the same as @SammysHP
Since the recent changes a caches opened in full detail level still needs another redownload once I trigger to save it to a list. Before those changes IMHO the save procedure was almost not noticeable since it was already cached.

@pstorch
Copy link
Contributor

pstorch commented Mar 20, 2016

Ah, I think I found it. I'm further investigating.

pstorch added a commit to pstorch/cgeo that referenced this issue Mar 20, 2016
Geocache.searchByGeocode() didn't recognize already cached Geocache correctly.
@pstorch
Copy link
Contributor

pstorch commented Mar 20, 2016

@SammysHP, @Lineflyer your questions led me to the right place.
The searchByGeocode() method didn't recognize anymore if the Geocache was already there (e.g. in the Cache). This was due to the wrong interpretation of the empty/not empty list.

samueltardieu added a commit that referenced this issue Mar 22, 2016
fix #5541: don't reload after adding to list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues classified as a bug
Projects
None yet
Development

No branches or pull requests

4 participants