Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Google static map feature #7332

Closed
Lineflyer opened this issue Feb 25, 2019 · 9 comments
Closed

Remove Google static map feature #7332

Lineflyer opened this issue Feb 25, 2019 · 9 comments
Assignees
Labels
Refactoring Issues requires code refactoring

Comments

@Lineflyer
Copy link
Member

Google stopped offering static maps for free. This is the reason, why the feature stopped working in c:geo. Details can be found here: #7150

The non working feature should be removed from c:geo as I don't expect Google to change its mind or c:geo team to be able to pay for such maps.

An alternative source (if there is any) could be implemented at the same step or afterwards.

Please be aware:
Currently all user installations will still send request to Google for static maps as the feature is still in and the default value is "Active". So removing it, might also a bit increase the performance.

@Lineflyer Lineflyer added the Refactoring Issues requires code refactoring label Feb 25, 2019
@bekuno
Copy link
Member

bekuno commented Feb 25, 2019

I could not find that the offering is stopped. I assume that the free limit
https://cloud.google.com/maps-platform/pricing/
is exhausted.
Maybe a limit per user could implemented in c:geo?

@Lineflyer
Copy link
Member Author

I could not find that the offering is stopped. I assume that the free limit
https://cloud.google.com/maps-platform/pricing/
is exhausted.
Maybe a limit per user could implemented in c:geo?

Thats correct and this limit is per key, not per user.
Obviiously 100000 maps seems not enough, as the maps are no longer working....or maybe we need to activate something on the Google account bound to our key before even the 100.000 maps are available.
Good question.

@bekuno
Copy link
Member

bekuno commented Feb 25, 2019

I mean a limit per device controlled by c:geo.

@moving-bits
Copy link
Member

We could circumvent this by giving the user a way to enter their own key. But IMHO users who are able (and willing) to apply for their own Google Maps API key would be fit enough to install an OSM offline map as well (and by this avoiding the problem completely).

@bekuno
Copy link
Member

bekuno commented Feb 25, 2019

We could circumvent this by giving the user a way to enter their own key.

The problem is not only the key "as such" - you have to specify a bank account.

@moving-bits
Copy link
Member

The problem is not only the key "as such" - you have to specify a bank account.

Yes, I know. And you can't even set a limit to always stay within the "free" limit. That's why I have switched my web projects away from Google Maps during the last months.

@Lineflyer
Copy link
Member Author

We could circumvent this by giving the user a way to enter their own key.

We discussed this some time ago, when we had to remove OpenCycleMap and decided against it. Maybe OK for some real "teccy" users, but IMHO not suitable for Google Maps...or do you know any other app, which requires users to add a bank account to their Google account and generate keys, etc.

@SammysHP
Copy link
Member

You can't even get a v1 key anymore. ;)

@moving-bits
Copy link
Member

In today's master static maps generation is only disabled to get the version out to market.
The feature still needs to be removed completely, so I reopen this issue.
[Reopening is for completely removing all static maps generation features only. If we want to implement a different provider for static maps, this should become a separate issue.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactoring Issues requires code refactoring
Projects
None yet
Development

No branches or pull requests

4 participants