Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more package names for Locus app (fix #11200) #11210

Merged
merged 1 commit into from Jul 12, 2021

Conversation

moving-bits
Copy link
Member

Description

Locus app uses several package names, depending on free/pro state and on distribution channel, see LocusUtil that comes with the integration files.
This PR adds the package names yet missing to AndroidManifest.xml to be able to query that package on Android 11 systems.

@moving-bits moving-bits self-assigned this Jul 12, 2021
Copy link
Member

@bekuno bekuno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bekuno bekuno merged commit 9577bb0 into cgeo:release Jul 12, 2021
@Lineflyer
Copy link
Member

Do we also need the same for maps.me (old name: mapswithme) ?
See #11134

@moving-bits
Copy link
Member Author

Do we also need the same for maps.me (old name: mapswithme) ?
See #11134

Sure. I just don't know their package names yet.

@fm-sys
Copy link
Member

fm-sys commented Jul 12, 2021

You can always easily use the web version of playstore to easily find the package name (contained in the URL)

@moving-bits
Copy link
Member Author

You can always easily use the web version of playstore to easily find the package name (contained in the URL)

Yes, I know, but have been too lazy (and too busy) to do this yet for those apps (and don't use them myself, so didn't know their package names yet).

@moving-bits moving-bits deleted the issue_11200 branch September 6, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants