Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some cleanups #15603

Merged
merged 2 commits into from Apr 14, 2024
Merged

some cleanups #15603

merged 2 commits into from Apr 14, 2024

Conversation

bekuno
Copy link
Member

@bekuno bekuno commented Apr 14, 2024

  • remove unused import
  • string "context_map_show_coords" is unused
  • style "cgeo.fullScreenDialog2" is unused
  • let "expand_collapsed" unused in code - @ztNFny ?
  • let "ic_menu_note" unused in code - @ztNFny ?

@bekuno
cleanups
cbe68da 
  - remove unused import
  - string "context_map_show_coords" is unused
  - style "cgeo.fullScreenDialog2" is unused
  - @ztNFny let "expand_collapsed" unused in code
  - @ztNFny let "ic_menu_note" unused in code
@bekuno bekuno requested a review from ztNFny April 14, 2024 12:02
@bekuno bekuno self-assigned this Apr 14, 2024
@ztNFny
Copy link
Contributor

ztNFny commented Apr 14, 2024

expand_collapsed was used in an earlier version of SimpleDialog, can be removed, can be easily added again if needed

ic_menu_note I'd propose to leave in, it's unused but the complimentary icon to ic_menu_note_edit, not unlikely we could need that again.

@bekuno
cleanups
13b87fd 
  - remove "expand_collapsed"
@bekuno
Copy link
Member Author

bekuno commented Apr 14, 2024

expand_collapsed was used in an earlier version of SimpleDialog, can be removed, can be easily added again if needed

ic_menu_note I'd propose to leave in, it's unused but the complimentary icon to ic_menu_note_edit, not unlikely we could need that again.

Ok, done.

@bekuno bekuno requested review from eddiemuc and removed request for ztNFny April 14, 2024 12:47
@bekuno bekuno merged commit 8fc0d5e into cgeo:master Apr 14, 2024
2 checks passed
@bekuno bekuno deleted the cleanup1 branch April 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddiemuc eddiemuc Awaiting requested review from eddiemuc

Assignees

@bekuno bekuno

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bekuno @ztNFny