Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #6259: do not save cookie store with Google #6269

Merged
merged 1 commit into from
Jan 17, 2017
Merged

fix #6259: do not save cookie store with Google #6269

merged 1 commit into from
Jan 17, 2017

Conversation

samueltardieu
Copy link
Member

Keeping the cookie store separate from the preferences allows not to
backup it with the backup manager.

Keeping the cookie store separate from the preferences allows not to
backup it with the backup manager.
@pstorch
Copy link
Contributor

pstorch commented Jan 17, 2017

Interesting. Didn't know about the concept of preferences backup via google. Had to look it up.
But the solution sounds plausible.

@pstorch
Copy link
Contributor

pstorch commented Jan 17, 2017

Should we also reset the cookies on CredentialPreference.revokeAuthorization()?
The AbstractLogin class has a resetLoginStatus() method.

@Lineflyer
Copy link
Member

As written in #6259 I suggest to put this to master only (and maybe also discuss the background and further steps).

@Lineflyer Lineflyer closed this Jan 17, 2017
@pstorch
Copy link
Contributor

pstorch commented Jan 17, 2017

@Lineflyer the target branch of a PR can also be changed via the edit button on top of the page. Ok, this doesn't work in all cases, but most of the time it is not needed to close and open a new PR.

@Lineflyer
Copy link
Member

Then lets @samueltardieu do the needful. :)

@Lineflyer Lineflyer reopened this Jan 17, 2017
@samueltardieu samueltardieu changed the base branch from release to master January 17, 2017 22:51
@samueltardieu samueltardieu merged commit b42cece into cgeo:master Jan 17, 2017
@samueltardieu samueltardieu deleted the issue-6259 branch January 17, 2017 22:52
@samueltardieu
Copy link
Member Author

Should we also reset the cookies on CredentialPreference.revokeAuthorization()?

Good idea, I'll do that in case of revocation of gc.com authorization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants