Implement authorization on geocaching.su #7170

okainov · 2018-10-27T01:52:04Z

Implements #5269

cgeo-bot · 2018-10-27T01:52:08Z

Can one of the admins verify this patch?

UniQP · 2018-10-27T11:07:50Z

I deleted the comments

UniQP · 2018-10-27T13:29:11Z

ok to test

Lineflyer · 2018-10-28T21:41:45Z

ok to test

cgeo-bot · 2018-10-28T21:44:18Z

Build finished.

Lineflyer · 2018-10-28T21:57:30Z

retest this please

cgeo-bot · 2018-10-28T21:59:42Z

Build finished.

okainov · 2018-10-29T16:57:38Z

@Lineflyer please add actual valid production Geocaching.su keys I sent before to keys.xml used in build

Lineflyer · 2018-10-29T20:09:23Z

@okainov I am unable to to lack of admin account and knowledge. I guess either @rsudev or @kumy can help with that?!

cgeo-bot · 2018-10-30T23:16:04Z

Build finished.

cgeo-bot · 2018-10-30T23:16:39Z

Build finished.

cgeo-bot · 2018-10-30T23:58:50Z

Build finished.

cgeo-bot · 2018-10-31T00:02:59Z

Build finished.

cgeo-bot · 2018-10-31T00:18:39Z

Build finished.

cgeo-bot · 2018-10-31T00:23:32Z

Build finished.

rsudev · 2018-10-31T20:09:10Z

Regarding the keys, either @kumy or @mucek4 can do that, I was only tangentially involved in the build-machinery until now.

rsudev · 2018-10-31T21:16:26Z

To give you a heads-up, I started to look at the PR. I will start putting out remarks tomorrow.
BTW: Is there a way to get keys for my developer build? (If you answered this already, please forgive me and kindly point me to the appropriate place)

okainov · 2018-10-31T21:20:55Z

@rsudev I just sent keys again to cgeo support mail. I was not able to quickly find way to message you directly, but feel free to provide a communication method to send you this directly

okainov · 2019-03-05T18:12:30Z

@Lineflyer @rsudev I improved OAuth part a bit to shorten the code and removed re-invented wheels, if there are more comments there let us continue improvements later there.

Lineflyer · 2019-03-15T16:04:59Z

@rsudev If you do not object today, I will merge this new connector tomorrow to give it a test in our nightlies.

Lineflyer · 2019-03-17T20:20:24Z

@okainov Can you rebase one more time? Recent commits produced a conflict.

Some OAuth servers implementation do not accept oauth_token parameter when it's empty, so ther eis no need to send empty option

Methods getTokenPublicPrefKeyId() and getTokenSecretPrefKeyId() are going to be reused in non-OC connectors, so let's create interface for general OAuth-capable connector

Instead of using hardcoded OC-only keys, get them dynamically Fixes: cgeo#7184

This class is being used outside of OC package, so need public access to its constructor.

- Implement SU Authorization activity - Implement SUParser and tests - Use new API for searching by geocode and map

Proper OAuth requires to do not store user credentials and to use tokens instead. - Changed SUAuthorizationActivity from Credentials-capable to OAuth-capable activity - Removed SuLogin and use OAuthAuthorizationActivity instead - Add User API call to get current user

Explicitly declare and catch possible exceptions during SuApi calls

Current behavior does not allow to have simple LoggingManager without implementing LoaderManager. See cgeo#7188

Caches loaded with old API didn't contain cache ID. However it's the main identifier on SU, and it can be easily computed from geocode. So, to avoid asking users to refresh all their caches it's easier to add this small fix.

Also, do not put all images in description, but only cache photo

okainov · 2019-03-18T19:12:32Z

@Lineflyer done

Lineflyer · 2019-03-18T20:32:08Z

This is a big one. Lets test.
I will merge as no one objected and this is the most meaningful point of time (most time before master might get to release)

@okainov
Thanks for your effort and for your patience with this one.
Hope you stay with it for maybe resulting bugfixes.
Regarding your open items (above) you might want to create issue as feature request documentation.

okainov · 2019-03-18T21:21:06Z

@Lineflyer you've squashed all my pretty commit history that I was trying to keep as neat as possible :( Can I have label near my nick or my PRs "please don't squash"?

Nevertheless, finally, hoorray! Thanks!

Lineflyer · 2019-03-18T21:25:49Z

Regarding the squashing:
I just followed the best practice we use here, that one PR is contained in one commit.

Regarding the final merge now:
Just want to give you the quick feeback, that the first impression for me as a tester is really positive. Authorization worked on first try. Speed and anticipated look and feel is matching :)

Lineflyer · 2019-03-18T21:29:08Z

BTW:
Any cache on this platform I can use for testing log posting (e.g. your owned or some test cache)?

okainov · 2019-03-18T21:36:33Z

I just followed the best practice we use here, that one PR is contained in one commit.

I think this shouldn't be applied for so huge changesets and when author has neat commit history, I think we had similar discussion with @rsudev somewhere in my previous PR. I'd be glad to organize my commits if they're not neat enough for you, but in the future I'd prefer to have them merged without squashing, because I try to separate them to logically independent parts for ease of tracking.

Any cache on this platform I can use for testing log posting (e.g. your owned or some test cache)?

Feel free to spam in my caches:
Traditional https://geocaching.su/?pn=101&cid=21372
Virtual https://geocaching.su/?pn=101&cid=21360
(there should be no changes in app behavior at the moment but just in case)

cgeo deleted a comment Oct 27, 2018

okainov force-pushed the su branch from 6518e98 to 0d46b3e Compare October 27, 2018 13:17

okainov changed the title ~~WIP: migrate SU to new API [Do Not Merge]~~ geocaching.su migrate SU to new API Oct 27, 2018

okainov force-pushed the su branch from ea61cdf to c0b4e71 Compare October 27, 2018 19:10

okainov changed the title ~~geocaching.su migrate SU to new API~~ Implement authorization on geocaching.su Oct 27, 2018

okainov force-pushed the su branch from c0b4e71 to b92b7a6 Compare October 27, 2018 19:37

Lineflyer requested review from kumy and rsudev October 30, 2018 13:51

okainov force-pushed the su branch from f5cc27f to d24aa80 Compare October 30, 2018 23:06

okainov force-pushed the su branch from cb1a618 to e8ef681 Compare October 30, 2018 23:50

okainov mentioned this pull request Oct 31, 2018

Next release #7174

Closed

Lineflyer requested a review from rsudev March 5, 2019 15:26

okainov force-pushed the su branch from 4002563 to 1743807 Compare March 5, 2019 18:08

okainov force-pushed the su branch from 1743807 to 03e8f28 Compare March 5, 2019 18:21

okainov added 16 commits March 18, 2019 16:54

OAuth: don't send empty token

2b45794

Some OAuth servers implementation do not accept oauth_token parameter when it's empty, so ther eis no need to send empty option

extract IOAuthCapability to separated interface

aa2eb5d

Methods getTokenPublicPrefKeyId() and getTokenSecretPrefKeyId() are going to be reused in non-OC connectors, so let's create interface for general OAuth-capable connector

OAuthPreference: fix auth status for non-OC services

a5cfe07

Instead of using hardcoded OC-only keys, get them dynamically Fixes: cgeo#7184

UserInfo: make constructor public

ac5ef74

This class is being used outside of OC package, so need public access to its constructor.

keys: add placeholders for SU in template

82a380a

geocaching.su: migrate to new API

91b291e

- Implement SU Authorization activity - Implement SUParser and tests - Use new API for searching by geocode and map

SuApi: add and use search by center

4c458ea

suApi: add and use posting images

34fd1a3

geocaching.su: catch possible exceptions

60d2210

Explicitly declare and catch possible exceptions during SuApi calls

geocaching.su: add watchlist support

0387793

geocaching.su: use Loader for logging

7b7477e

Current behavior does not allow to have simple LoggingManager without implementing LoaderManager. See cgeo#7188

geocaching.su: use HTTPS

721e7b9

geocaching.su: add uploading personal notes

c346f29

geocache: add getting cache ID from geocode for SU

e459560

Caches loaded with old API didn't contain cache ID. However it's the main identifier on SU, and it can be easily computed from geocode. So, to avoid asking users to refresh all their caches it's easier to add this small fix.

geocaching.su: add description paragraphs

cb588ff

Also, do not put all images in description, but only cache photo

okainov force-pushed the su branch from 03e8f28 to cb588ff Compare March 18, 2019 17:28

Lineflyer merged commit 8c15c7e into cgeo:master Mar 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement authorization on geocaching.su #7170

Implement authorization on geocaching.su #7170

okainov commented Oct 27, 2018 •

edited

cgeo-bot commented Oct 27, 2018

UniQP commented Oct 27, 2018

UniQP commented Oct 27, 2018

Lineflyer commented Oct 28, 2018

cgeo-bot commented Oct 28, 2018

Lineflyer commented Oct 28, 2018

cgeo-bot commented Oct 28, 2018

okainov commented Oct 29, 2018

Lineflyer commented Oct 29, 2018

cgeo-bot commented Oct 30, 2018

cgeo-bot commented Oct 30, 2018

cgeo-bot commented Oct 30, 2018

cgeo-bot commented Oct 31, 2018

cgeo-bot commented Oct 31, 2018

cgeo-bot commented Oct 31, 2018

rsudev commented Oct 31, 2018

rsudev commented Oct 31, 2018

okainov commented Oct 31, 2018

okainov commented Mar 5, 2019 •

edited

Lineflyer commented Mar 15, 2019

Lineflyer commented Mar 17, 2019

okainov commented Mar 18, 2019

Lineflyer commented Mar 18, 2019

okainov commented Mar 18, 2019

Lineflyer commented Mar 18, 2019

Lineflyer commented Mar 18, 2019

okainov commented Mar 18, 2019 •

edited

Implement authorization on geocaching.su #7170

Implement authorization on geocaching.su #7170

Conversation

okainov commented Oct 27, 2018 • edited

cgeo-bot commented Oct 27, 2018

UniQP commented Oct 27, 2018

UniQP commented Oct 27, 2018

Lineflyer commented Oct 28, 2018

cgeo-bot commented Oct 28, 2018

Lineflyer commented Oct 28, 2018

cgeo-bot commented Oct 28, 2018

okainov commented Oct 29, 2018

Lineflyer commented Oct 29, 2018

cgeo-bot commented Oct 30, 2018

cgeo-bot commented Oct 30, 2018

cgeo-bot commented Oct 30, 2018

cgeo-bot commented Oct 31, 2018

cgeo-bot commented Oct 31, 2018

cgeo-bot commented Oct 31, 2018

rsudev commented Oct 31, 2018

rsudev commented Oct 31, 2018

okainov commented Oct 31, 2018

okainov commented Mar 5, 2019 • edited

Lineflyer commented Mar 15, 2019

Lineflyer commented Mar 17, 2019

okainov commented Mar 18, 2019

Lineflyer commented Mar 18, 2019

okainov commented Mar 18, 2019

Lineflyer commented Mar 18, 2019

Lineflyer commented Mar 18, 2019

okainov commented Mar 18, 2019 • edited

okainov commented Oct 27, 2018 •

edited

okainov commented Mar 5, 2019 •

edited

okainov commented Mar 18, 2019 •

edited