Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cache filters for stored within or before last 8h / 24h / 7d / 30d #7768

Merged
merged 5 commits into from Aug 20, 2019

Conversation

moving-bits
Copy link
Member

@moving-bits moving-bits commented Aug 1, 2019

Fixes #7498

add cache filters for "stored within xxx" and their opposite ("stored before xxx") with xxx = any of 8 hours, 24 hours, 7 days, 30 days

@moving-bits moving-bits self-assigned this Aug 1, 2019
@moving-bits moving-bits changed the title add cache filters for stored within last 8h / 24h / 7d / 30d add cache filters for stored within or before last 8h / 24h / 7d / 30d Aug 1, 2019
@moving-bits
Copy link
Member Author

moving-bits commented Aug 2, 2019

While looking over this PR I am a bit confused why those strings above have already been included before.
AFAIR there was no filter of such kind in the past, was it?

I created this PR in two steps (two commits): First the positive conditions ("saved within xxx") and strings needed for this, then the negative conditions ("not saved within xxx"). For consistency between the two blocks I had to adjust some strings from the first commit.

@Lineflyer Lineflyer added the Do not merge / WIP Not for merging and/or work still in progress label Aug 18, 2019
@Lineflyer
Copy link
Member

Agreed to be revisited by @moving-bits due to better sequence in filter menus / sub menus.

@moving-bits
Copy link
Member Author

Moved the eight new filters together with the two existing filters "Stored" and "Not stored" into its own filter category "stored" (directly below category "status"):

image

@moving-bits
Copy link
Member Author

Agreed to be revisited by @moving-bits due to better sequence in filter menus / sub menus.

done

@moving-bits moving-bits added Field test Issue to be (re)tested in the field and removed Do not merge / WIP Not for merging and/or work still in progress labels Aug 19, 2019
@Lineflyer Lineflyer merged commit 2cbcf71 into cgeo:master Aug 20, 2019
@moving-bits moving-bits deleted the issue_7498 branch August 24, 2019 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Field test Issue to be (re)tested in the field
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter by time of last update (to limit refresh of caches)
2 participants