Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP ease offline maps onboarding #8183

Merged
merged 4 commits into from
Jun 14, 2020
Merged

WIP ease offline maps onboarding #8183

merged 4 commits into from
Jun 14, 2020

Conversation

moving-bits
Copy link
Member

@moving-bits moving-bits commented Apr 8, 2020 •
edited
Loading

This is a WIP for beta testing only - do not merge

  • integrate locally stored OSM map file into c:geo
    • move to map dir (cancellable)
    • set as current map source
  • add preference link to download v3 OSM files
  • improve handling of local files (forward detected file types internally, show an info message for the rest)
  • smoke tested with different file types and Android versions from 4 to 10

For details and current status see #8180.

@moving-bits moving-bits added Field test Issue to be (re)tested in the field Do not merge / WIP Not for merging and/or work still in progress labels Apr 8, 2020
@moving-bits moving-bits self-assigned this Apr 8, 2020
@moving-bits moving-bits mentioned this pull request Apr 8, 2020
Closed
3 tasks
@moving-bits moving-bits force-pushed the issue_8180 branch 4 times, most recently from 79d33c5 to a489102 Compare April 12, 2020 18:35
@moving-bits moving-bits mentioned this pull request Apr 13, 2020
Closed
@moving-bits
Copy link
Member Author

moving-bits commented Apr 18, 2020 •
edited
Loading

(rebased to current master and resolved merge conflicts introduced by moving the non translatable strings)

@Lineflyer
Copy link
Member

It makes IMHO no sense to make use of V3 maps as these maps are no longer updated since a longer time on the mapsforge servers. That will in return give complaints of outdated maps.
You probably used that version to be compatible to WhereYouGo, but IMHO it makes more sense to rather make a c:geo solution with newer maps and wait with WhereYouGo until we have support for higher versions in there.

@moving-bits
Copy link
Member Author

Ok, shall I make it download a v5 map instead, then, or shall I make this dependent on the "use old Mapsforge v3" setting?

@Lineflyer
Copy link
Member

IMHO the setting to use old mpasforge is for experienced users (and might hopefully be removed rather soon).
Therefore I suggest to go for V5 as a straight default.

@moving-bits
Copy link
Member Author

Rebased to current master and changed map dir to v5 maps.

@moving-bits moving-bits mentioned this pull request May 13, 2020
Closed
@moving-bits
Ease onboarding for offline OSM map usage
cca21fd 
- detect file type of of local files
- copy map file to c:geo map storage
- set copied map as current map
- add preference link to download v3 OSM files
@moving-bits
Add cancellable progress dialog to map copy process
94143d7
@moving-bits
Tweak manifest settings to enhance compatibility with more file manag…
f5a7ce2 
…ement apps
@moving-bits
use v5 OSM as downloadable map
35365c6
@moving-bits
Copy link
Member Author

Rebased to current master

@moving-bits moving-bits removed the Do not merge / WIP Not for merging and/or work still in progress label Jun 13, 2020
@cgeo-ci-bot Codacy Production
Copy link
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- main/src/cgeo/geocaching/activity/Progress.java  1
- main/src/cgeo/geocaching/settings/AbstractInfoPreference.java  1
- main/src/cgeo/geocaching/settings/ReceiveMapFileActivity.java  10
- main/src/cgeo/geocaching/HandleLocalFilesActivity.java  15
- main/src/cgeo/geocaching/settings/InfoPreferenceMap.java  1
- main/src/cgeo/geocaching/files/FileTypeDetector.java  1

See the complete overview on Codacy

@moving-bits moving-bits merged commit f607fbc into cgeo:master Jun 14, 2020
@moving-bits moving-bits deleted the issue_8180 branch June 14, 2020 07:14
@moving-bits moving-bits mentioned this pull request Jun 19, 2020
Closed
This was referenced Jul 11, 2020
Closed
Closed
moving-bits added a commit to moving-bits/cgeo that referenced this pull request Jul 12, 2020
@moving-bits
disable cgeo#8183, restore old AndroidManifest
3236caf
@moving-bits moving-bits mentioned this pull request Jul 12, 2020
Merged
moving-bits added a commit that referenced this pull request Jul 12, 2020
@moving-bits
disable #8183, restore old AndroidManifest
2b0b3a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@moving-bits moving-bits

Labels
Field test Issue to be (re)tested in the field
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moving-bits @Lineflyer @cgeo-ci-bot