Support other OSM based online map sources (fix #8148)

[moving-bits]

Extend our supported OSM based online maps by

• openstreetmap.de and
• cyclosm.org

Avaialble for NewMap only.
Also renamed "OpenStreetMap" to "OpenStreetMap.org" to distinguish from "OpenStreetMap.de".

Example screen shots:

OpenStreetMap.org (aka "OSM:Mapnik")

OpenStreetMap.de:

CyclOSM.org:

[moving-bits]

"Help wanted":

Current implementation seems to work fine so far, with one caveat which I haven't been able to tackle yet: After switching between two of the three OSM online services the map stays blank until you close and reopen the map. (This does not happen when switching from an online based map to an offline based map and vice versa.) So there seems to be one additional step needed.

Solved

[cgeo-ci-bot]

Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- main/src/cgeo/geocaching/maps/mapsforge/TileSourceOsmde.java  1
- main/src/cgeo/geocaching/maps/mapsforge/TileSourceCyclosm.java  1
         

See the complete overview on Codacy

[SammysHP]

Do you have a permission for us to use these maps?

cyclosm.org:

A Tile Map Service is available at https://{s}.tile-cyclosm.openstreetmap.fr/cyclosm/{z}/{x}/{y}.png under a fairuse tile policy.

https://operations.osmfoundation.org/policies/tiles/:

Heavy use (e.g. distributing an app that uses tiles from openstreetmap.org) is forbidden without prior permission from the Operations Working Group.

openstreetmap.de has something similar:

https://www.openstreetmap.de/germanstyle.html

Das Einbinden der Kacheln in eigene Webseites können wir aufgrund der begrenzten Bandbreite leider nur für nichtkommerzielle Zwecke erlauben. Kleinere Webanwendungen, wie z.B. der Anfahrtsplan auf der Firmenwebseite dürfen die Kacheln selbstverständlich verwenden. Bitte beachten sie auch die Tile usage policy.

[moving-bits]

Do you have a permission for us to use these maps?

Both new sources refer to the identical policy we already have for our current OSM online tile server, and attribution notes have been extended to list the two new sources.

[moving-bits]

retest this please

[SammysHP]

Both new sources refer to the identical policy we already have for our current OSM online tile server

And nobody said that it is OK what we do. ;)

[moving-bits]

And nobody said that it is OK what we do. ;)

The comment openstreetmap/operations#371 (comment) can be read as a "temporarily ok, until we say otherwise".

This PR intends to reduce load on that server by distributing it over several different sources, hopefully resulting in low/acceptable load for all servers involved.

#8180 tries to help new users to configure offline map sources more easily to make more users of c:geo use offline maps.

[moving-bits]

retest this please