Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update widget icons #9098

Merged
merged 1 commit into from
Oct 4, 2020
Merged

Conversation

fm-sys
Copy link
Member

@fm-sys fm-sys commented Sep 30, 2020

related to #8661 and #8659 we should also update our widget icons:

Screenshot_20200930_132212 --> Screenshot_20200930_132118_com huawei android launcher

@fm-sys fm-sys self-assigned this Sep 30, 2020
@bekuno
Copy link
Member

bekuno commented Sep 30, 2020

The icons are created dynamicly - long press the c:geo icon, then you have also the 4 icons for the shortcuts shown. Now long press on such icon - you can create the launcher icon with the new c:geo image (very small in the edge in my case).
I don't know when it was implemented.

By the way, I can not create a "Go To" icon in this way, and the "Verlauf" icon has on my phone the text "Gespeichert".

You are right that the launcher icons needs the refresh.
I asume that we need an update routine, isnt it?

(tested with 2020.08.04)

@fm-sys
Copy link
Member Author

fm-sys commented Sep 30, 2020

Amazing! I did not know this option... But this PR is about the widgets you can insert in your launcher via "widgets > c:geo Shortcut"

But we should probably match the c:geo icon size for the two different types, shouldn't we?

@bekuno
Copy link
Member

bekuno commented Sep 30, 2020

But we should probably match the c:geo icon size for the two different types, shouldn't we?

That would great.
And also the same icons and text.

For the icon principle - shouldn't it the oposite presentation - as base the c:geo icon and overlay the extra function? (as for contacts plugin)
@Lineflyer Was there such discussion in the past?

@fm-sys
Copy link
Member Author

fm-sys commented Sep 30, 2020

For the icon principle - shouldn't it the oposite presentation - as base the c:geo icon and overlay the extra function? (as for contacts plugin)

Would also be fine for me. But note that this could not be done for the shortcuts created as you described above...

long press the c:geo icon, then you have also the 4 icons for the shortcuts shown. Now long press on such icon - you can create the launcher icon with the new c:geo image (very small in the edge in my case)

@Lineflyer
Copy link
Member

@Lineflyer Was there such discussion in the past?

I remember, that we choose this because the user might want to easily identify which widget shortcut he is about to use latest in case he uses more than one.
Secondly it matches the built in shortcuts mentioned above.

@moving-bits
Copy link
Member

I'm unsure about the state of discussion in this case. Any changes planned for this PR, or is it ready to merge?

@bekuno
Copy link
Member

bekuno commented Oct 2, 2020

From my taste I would have the c:geo icon a little bit smaller.

A update routine can go to another PR, imho.

@Lineflyer
Copy link
Member

I am fine with this PR.

@moving-bits moving-bits merged commit 08c5628 into cgeo:master Oct 4, 2020
@fm-sys fm-sys deleted the launcher_shortcut_icons branch October 20, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants