Import libraries when they are needed #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, can you point me to the right branch of |
|
Looks good! Thanks a lot @alcuadrado. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Chris!
This is a quick PR to optimize this plugin. The change introduced here is that it now imports external libraries right before they are needed. This means that they are not loaded during Hardhat initialization, so that Hardhat loads faster. You can appreciate the difference if you run a
npx hardhat --helpin a project using this version of the plugin andlatest.The difference is not huge, but it compounds with other plugins, so I'm doing this for every plugin included in the hardhat toolbox. I'll also send a similar PR to
solidity-coverage.A test is failing, but it was also failing onIt passes on the CImaster. I can fix it, but I may require some guidance.