Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fill value for GFF3 attributes #223

Merged
merged 5 commits into from Dec 20, 2018
Merged

Fix fill value for GFF3 attributes #223

merged 5 commits into from Dec 20, 2018

Conversation

alimanfoo
Copy link
Contributor

Use '.' instead of b'.' for attributes fill values when reading GFF3, resolves #165.

Also refactors IO tests into a allel/test/io package.

@alimanfoo alimanfoo added this to the v1.2 milestone Nov 14, 2018
@pep8speaks
Copy link

Hello @alimanfoo! Thanks for updating the PR.

@alimanfoo alimanfoo merged commit 1e5bc20 into cggh:master Dec 20, 2018
@alimanfoo alimanfoo deleted the gff-fill-alimanfoo-20181114 branch December 20, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardingnj hardingnj Awaiting requested review from hardingnj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

GFF3 attributes fill b'.' should be '.'
2 participants
@alimanfoo @pep8speaks