Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fill value for GFF3 attributes #223

Merged
merged 5 commits into from Dec 20, 2018

Conversation

Projects
None yet
2 participants
@alimanfoo
Copy link
Contributor

commented Nov 14, 2018

Use '.' instead of b'.' for attributes fill values when reading GFF3, resolves #165.

Also refactors IO tests into a allel/test/io package.

@alimanfoo alimanfoo requested a review from hardingnj Nov 14, 2018

@alimanfoo alimanfoo added this to the v1.2 milestone Nov 14, 2018

@alimanfoo alimanfoo force-pushed the alimanfoo:gff-fill-alimanfoo-20181114 branch from bab64c0 to 789aec9 Dec 20, 2018

@pep8speaks

This comment has been minimized.

Copy link

commented Dec 20, 2018

Hello @alimanfoo! Thanks for updating the PR.

@alimanfoo alimanfoo merged commit 1e5bc20 into cggh:master Dec 20, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alimanfoo alimanfoo deleted the alimanfoo:gff-fill-alimanfoo-20181114 branch Dec 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.