Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Transfer duplicate pokemon should also use exceptions.config #36

Closed
Necroskillz opened this issue Aug 1, 2016 · 7 comments
Closed
Assignees

Comments

@Necroskillz
Copy link

I could pull request if u want, but it's pretty simple change that should be easy enough to do for you.

@cglatot cglatot changed the title Transfer duplicate pokemon should also use exceptions.config [Feature] Transfer duplicate pokemon should also use exceptions.config Aug 1, 2016
@cglatot cglatot self-assigned this Aug 1, 2016
@fprovostpoulin
Copy link

I'd like to have this change as well. It would also be nice to have a CP range as well for the dupplicate transfer. Maybe it could be a different exception file for the dupplicates. So I could (lets say) remove All duplicates under X CP and X IV except Pidgey, Caterpie and weedles. Thanks

@cglatot
Copy link
Owner

cglatot commented Aug 2, 2016

Solved with commit #40 by @bartonp

@cglatot cglatot closed this as completed Aug 2, 2016
@bartonp
Copy link
Contributor

bartonp commented Aug 2, 2016

@fprovostpoulin and @cglatot - I have the code for the CP limitation as a global input already. Do you want me to create another pull request or just add it into this one? It's located on this commit if you want to diff it -> bartonp@80dd12f

The separate file would have to be worked out into a different way as you could then have different levels per pokemon.

@cglatot
Copy link
Owner

cglatot commented Aug 2, 2016

I've added the CP cutoff - but I do not like the idea of the different files - I don't want this to be getting too complex. There are already so many options to make, I don't see the need for it.

@fprovostpoulin
Copy link

This is perfect asis ! Maybe adding a question for CP as you do for single
transfer, that would be awesome.

Another thing that could be a nice option is to be able to transfer all the
Non-starred or all of th Starred pokemon. What do you think ?

Thank you very much !

Félix Provost-Poulin

Software Engeneer Bacc. and MBA Candidate
Cellulaire : (514) 463-1978

2016-08-02 17:54 GMT-04:00 cglatot notifications@github.com:

I've added the CP cutoff - but I do not like the idea of the different
files - I don't want this to be getting too complex. There are already so
many options to make, I don't see the need for it.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#36 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARHK37MQ3rZKfS8x5-sg8UzqdVBrzs1Lks5qb7yjgaJpZM4JZ9E2
.

@cglatot
Copy link
Owner

cglatot commented Aug 3, 2016

@fprovostpoulin - I've already added the CP cutoff - look at my last reply.

The transfer duplicates already won't transfer your starred pokemon. Not going to add a separate feature for it

@fprovostpoulin
Copy link

Okay; I didn't know it wasnt transfering starred pokemon; Maybe you could
just put a note into your user guide :)
Thanks

Félix Provost-Poulin

Software Engeneer Bacc. and MBA Candidate
Cellulaire : (514) 463-1978

2016-08-03 1:28 GMT-04:00 cglatot notifications@github.com:

@fprovostpoulin https://github.com/fprovostpoulin - I've already added
the CP cutoff - look at my last reply.

The transfer duplicates already won't transfer your starred pokemon. Not
going to add a separate feature for it


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#36 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ARHK36aoGudB4rm4Dg9jQ5johTwdb7qhks5qcCcKgaJpZM4JZ9E2
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants