Skip to content

Commit

Permalink
implement issue #216
Browse files Browse the repository at this point in the history
  • Loading branch information
cgnieder committed Jan 4, 2022
1 parent 2f8d988 commit 21fe2d7
Show file tree
Hide file tree
Showing 2 changed files with 34 additions and 4 deletions.
13 changes: 13 additions & 0 deletions code/acro.patch.code.tex
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,22 @@
\acro_new_patch:n {tabu}
\acro_new_patch:n {ltxtable}
\acro_new_patch:n {caption}
\acro_new_patch:n {maketitle}

\AtEndPreamble
{
% maketitle:
\acro_if_patch:nT {maketitle}
{
\pretocmd \maketitle
{ \acswitchoff }
{}
{ \msg_error:nnn {acro} {patch} {maketitle} }
\apptocmd \maketitle
{ \acswitchon }
{}
{ \msg_error:nnn {acro} {patch} {maketitle} }
}
% floats:
\acro_if_patch:nT {floats}
{
Expand Down
25 changes: 21 additions & 4 deletions code/acro.sty
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
\msg_new:nnn {acro} {unknown-option}
{
Unknown~ option~ `#1' \\
I~ don't~ know~ the~ option~ `#1'.~ Please~ make~ sure~ there~ is~ no~
I~ dont'~ know~ the~ option~ `#1'.~ Please~ make~ sure~ there~ is~ no~

This comment has been minimized.

Copy link
@dbitouze

dbitouze Jan 4, 2022

Contributor

I don't see the point of this change.

This comment has been minimized.

Copy link
@cgnieder

cgnieder Jan 4, 2022

Author Owner

this just fixes a typo :)

This comment has been minimized.

Copy link
@dbitouze

dbitouze Jan 4, 2022

Contributor

If I understand correctly, you replaced "don't" with "dont'". Isn't it the latter that has a typo?

This comment has been minimized.

Copy link
@cgnieder

cgnieder Jan 4, 2022

Author Owner

You're absolutely right…
This was part of a merge request which I apparently haven't check carefully enough. I'll fix it again.

typo.~ Check~ the~ manual~ for~ help.
}

Expand Down Expand Up @@ -748,7 +748,7 @@
\acro_property_make_alias:nn {#6} {#7}
}

\NewDocumentCommand \MakeAcroPropertyAlias {mm}
\NewDocumentCommand \MakeAcroPropertyAlias{mm}
{ \acro_property_make_alias:nn {#1} {#2} }

\NewDocumentCommand \NewAcroPreset {m+m}
Expand Down Expand Up @@ -3852,8 +3852,8 @@
\acro_if_komascript:TF
{
\cs_if_exist:NTF \chapter
{ \keys_set:nn {acro/list}{ heading = addchap } }
{ \keys_set:nn {acro/list}{ heading = addsec } }
{ \keys_set:nn {acro/list}{ heading = addchap* } }
{ \keys_set:nn {acro/list}{ heading = addsec* } }
}
{
\cs_if_exist:NTF \chapter
Expand Down Expand Up @@ -5067,9 +5067,22 @@
\acro_new_patch:n {tabu}
\acro_new_patch:n {ltxtable}
\acro_new_patch:n {caption}
\acro_new_patch:n {maketitle}

\AtEndPreamble
{
% maketitle:
\acro_if_patch:nT {maketitle}
{
\pretocmd \maketitle
{ \acswitchoff }
{}
{ \msg_error:nnn {acro} {patch} {maketitle} }
\apptocmd \maketitle
{ \acswitchon }
{}
{ \msg_error:nnn {acro} {patch} {maketitle} }
}
% floats:
\acro_if_patch:nT {floats}
{
Expand Down Expand Up @@ -5295,6 +5308,8 @@
{
\NewAcroTemplate[heading] {addsec}
{ \addsec { \acrolistname } }
\NewAcroTemplate[heading] {addsec*}
{ \addsec* { \acrolistname } }
}

\cs_if_exist:NT \chapter
Expand All @@ -5307,6 +5322,8 @@
{
\NewAcroTemplate[heading] {addchap}
{ \addchap { \acrolistname } }
\NewAcroTemplate[heading] {addchap*}
{ \addchap* { \acrolistname } }
}
}

Expand Down

0 comments on commit 21fe2d7

Please sign in to comment.