Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-103525 Update enable/disable logic in CanonicalURL and move to top #420

Closed
wants to merge 3 commits into from
Closed

LPS-103525 Update enable/disable logic in CanonicalURL and move to top #420

wants to merge 3 commits into from

Conversation

boton
Copy link

@boton boton commented Nov 4, 2019

No description provided.

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@cgoncas
Copy link
Owner

cgoncas commented Nov 4, 2019

ci:test:sf

@cgoncas
Copy link
Owner

cgoncas commented Nov 4, 2019

ci:test:relevant

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:ci:test:sf - 1 out of 1 jobs passed in 4 minutes 21 seconds 458 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0bd2acaaf1b5db078068c1d45bfe7caf93b7aa51

Sender Branch:

Branch Name: LPS-103525-seo-enable-disable-fields
Branch GIT ID: 90688cefc3f2f1f0ce5f632675fd0abfa4c46a57

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:stable - 8 out of 9 jobs passed

❌ ci:test:relevant - 21 out of 25 jobs passed in 1 hour 18 minutes 11 seconds 121 ms

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 0bd2acaaf1b5db078068c1d45bfe7caf93b7aa51

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: d958c23bf0f88697d5d9ae0808ba5d4b86986ca1

ci:test:stable - 8 out of 9 jobs PASSED
8 Successful Jobs:
ci:test:relevant - 21 out of 25 jobs PASSED
21 Successful Jobs:
For more details click here.

This pull contains no unique failures.

Failures in common with acceptance upstream results at 0bd2aca:
  3. test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql57-jdk8
    Job Results:

    928 Tests Passed.
    1 Test Failed.

    1. AXIS_VARIABLE=1,label_exp=!master #294464
      1. AssetDisplayPageFormProcessorTest.testProcessWithDefaultParameters
        java.lang.AssertionError: expected:<45916> but was:<0>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:834)
	at org.junit.Assert.assertEquals(Assert.java:645)
	at org.junit.Assert.assertEquals(Assert.java:631)
	at com.liferay.layout.type.controller.asset.display.test.AssetDisplayPageFormProcessorTest.lambda$testProcessWithDefaultParameters$5(AssetDisplayPageFormProcessorTest.java:311)
	at com.liferay.layout.type.controller.asset.display.test.AssetDisplayPageFormProcessorTest._withAndWithoutAssetEntry(AssetDisplayPageFormProcessorTest.java:387)
	at com.liferay.layout.type.controller.asset.display.test.AssetDisplayPageFormProcessorTest.testProcessWithDefaultParameters(AssetDisplayPageFormProcessorTest.java:298)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at com.liferay.arquillian.extension.junit.bridge.server.TestExecutorRunnable$2.evaluate(TestExecutorRunnable.java:234)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2.evaluate(AbstractTestRule.java:99)
	at com.liferay.portal.kernel.test.rule.AbstractTestRule$2...

@cgoncas
Copy link
Owner

cgoncas commented Nov 4, 2019

Just started reviewing :)

:octocat: Sent from GH.

@cgoncas
Copy link
Owner

cgoncas commented Nov 5, 2019

Pull request submitted to boton#100. See changes here.

:octocat: Sent from GH.

@cgoncas cgoncas closed this Nov 5, 2019
@boton boton deleted the LPS-103525-seo-enable-disable-fields branch January 14, 2020 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - failure ci:test:sf - success ci:test:stable - failure
Projects
None yet
Milestone
No milestone
3 participants
@boton @liferay-continuous-integration @cgoncas