Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-114512 Invalid search filter when using Organizations in Segments Criteria Builder #499

Closed
wants to merge 1 commit into from
Closed

LPS-114512 Invalid search filter when using Organizations in Segments Criteria Builder #499

wants to merge 1 commit into from

Conversation

darquesdev
Copy link

@darquesdev darquesdev commented May 28, 2020 •
edited

Hi @brianchandotcom, this commit is really needed since we're getting rid of the last comma in case there are no more organizations

@liferay-continuous-integration
Copy link
Collaborator

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

@darquesdev
Copy link
Author

ci:test:relevant

@darquesdev
Copy link
Author

ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 4 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ae164e4f5859d26a26c7a2600dd40044aad0aa8

Sender Branch:

Branch Name: LPS-114512
Branch GIT ID: edda86ede4fbdd22658aef64c0061f726e08cae2

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@cgoncas
Copy link
Owner

cgoncas commented May 28, 2020

ci:test:forward

@liferay-continuous-integration
Copy link
Collaborator

The test will not be initiated because ci:test:forward is not a valid command. Please use ci:forward instead.

@cgoncas
Copy link
Owner

cgoncas commented May 28, 2020

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@darquesdev
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:sf - 1 out of 1 jobs passed in 3 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ae164e4f5859d26a26c7a2600dd40044aad0aa8

Sender Branch:

Branch Name: LPS-114512
Branch GIT ID: c0fe1cb50c2f7d3238efc3a845a670f8ff884d05

1 out of 1jobs PASSED
1 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ae164e4f5859d26a26c7a2600dd40044aad0aa8

ci:test:relevant - 0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

    The sender branch SHA could not be found on darquesdev/LPS-114512. The sender branch may have been force pushed or deleted after the pull request test was initiated.

    fatal: Not a valid branch point: 'edda86ede4fbdd22658aef64c0061f726e08cae2'.

For upstream results, click here.

@darquesdev
Copy link
Author

ci:forward

@liferay-continuous-integration
Copy link
Collaborator

CI is automatically triggering the following test suites:

  •     ci:test:relevant
  •     ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

  •     ci:test:relevant
  •     ci:test:sf
  •     ci:test:stable

@liferay-continuous-integration
Copy link
Collaborator

Skipping previously passed test suites:
ci:test:sf

@liferay-continuous-integration
Copy link
Collaborator

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ae164e4f5859d26a26c7a2600dd40044aad0aa8

ci:test:relevant - 0 out of 1 jobs PASSED
For more details click here.

Failures unique to this pull:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    0 Jobs Passed.
    1 Job Failed.

    The sender branch SHA could not be found on darquesdev/LPS-114512. The sender branch may have been force pushed or deleted after the pull request test was initiated.

    fatal: Not a valid branch point: 'edda86ede4fbdd22658aef64c0061f726e08cae2'.

For upstream results, click here.

@jpince jpince mentioned this pull request May 28, 2020
Closed
@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 19 out of 19 jobs passed

✔️ ci:test:relevant - 43 out of 43 jobs passed in 2 hours 39 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ae164e4f5859d26a26c7a2600dd40044aad0aa8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6845814bf7a2b1b38f7c5a057c77bb287029faf4

ci:test:stable - 19 out of 19 jobs PASSED
19 Successful Jobs:
ci:test:relevant - 43 out of 43 jobs PASSED
43 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#89337

@liferay-continuous-integration
Copy link
Collaborator

✔️ ci:test:stable - 19 out of 19 jobs passed

✔️ ci:test:relevant - 43 out of 43 jobs passed in 3 hours 7 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 4ae164e4f5859d26a26c7a2600dd40044aad0aa8

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6845814bf7a2b1b38f7c5a057c77bb287029faf4

ci:test:stable - 19 out of 19 jobs PASSED
19 Successful Jobs:
ci:test:relevant - 43 out of 43 jobs PASSED
43 Successful Jobs:
For more details click here.

@liferay-continuous-integration
Copy link
Collaborator

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

Closed
@liferay-continuous-integration
Copy link
Collaborator

Pull request has been successfully forwarded to brianchandotcom#89342

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#5538
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:cgoncas#499
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:test-1-7/test-portal-acceptance-pullrequest(master)/5538 - 2020-05-28[08:18:21]
Spira Jenkins Build:publish-spira-report#143

@liferay-continuous-integration
Copy link
Collaborator

Jenkins Build:test-portal-acceptance-pullrequest(master)#5647
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:cgoncas#499
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:test-1-8/test-portal-acceptance-pullrequest(master)/5647 - 2020-05-28[08:19:10]
Spira Jenkins Build:publish-spira-report#203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci:test:relevant - success ci:test:sf - success ci:test:stable - success
Projects
None yet
Milestone
No milestone
3 participants
@darquesdev @liferay-continuous-integration @cgoncas