LPS-114284 Sort constructor params and minor SF changes #506

cgoncas · 2020-06-01T14:51:14Z

No description provided.

liferay-continuous-integration · 2020-06-01T14:51:18Z

To conserve resources, the PR Tester does not automatically run for every pull.

If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed.

If your pull was never tested, comment "ci:test" to run the PR Tester for this pull.

cgoncas · 2020-06-01T14:51:25Z

ci:forward

liferay-continuous-integration · 2020-06-01T14:51:29Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-06-01T15:05:59Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 14 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 17b531d5af5ab10d7deb3e0b433495c62cc54f6c

Sender Branch:

Branch Name: LPS-114284
Branch GIT ID: fc76977b2987e15afc516c32c581307744d4cc39

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-06-01T17:04:22Z

✔️ ci:test:stable - 19 out of 19 jobs passed

❌ ci:test:relevant - 112 out of 115 jobs passed in 2 hours 12 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: 845593ae0118a5578e82f561a56ebe247c393393

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6845814bf7a2b1b38f7c5a057c77bb287029faf4

ci:test:stable - 19 out of 19 jobs PASSED

19 Successful Jobs:

ci:test:relevant - 112 out of 115 jobs PASSED

3 Failed Jobs:

112 Successful Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3
Job Results:
10 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=1,label_exp=!master #359926
  1. LocalFile.ContentPages#ViewRestrictionVisualFeedbackWhenDragSectionCardOverColumnOfRow - Poshi Report - Poshi Summary - Console Output
test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/43
Job Results:
23 Tests Passed.
1 Test Failed.
1. AXIS_VARIABLE=2,label_exp=!master #321274
  1. LocalFile.WebContentDisplay#SelectWebContent - Poshi Report - Poshi Summary - Console Output

For upstream results, click here.

cgoncas · 2020-06-01T17:27:31Z

ci:test:relevant

…d getGenericClassName.

cgoncas · 2020-06-01T17:29:22Z

ci:stop

cgoncas · 2020-06-01T17:29:51Z

ci:forward

liferay-continuous-integration · 2020-06-01T17:29:54Z

CI is automatically triggering the following test suites:

ci:test:relevant
ci:test:sf

The pull request will automatically be forwarded to the user brianchandotcom if the following test suites pass:

ci:test:relevant
ci:test:sf
ci:test:stable

liferay-continuous-integration · 2020-06-01T17:37:26Z

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e3871929988f0958ef362c67fda0985c24454c81

Sender Branch:

Branch Name: LPS-114284
Branch GIT ID: d4e48001896e0c790a2f461ab7da2bfb415b731a

1 out of 1jobs PASSED

1 Successful Jobs:

test-portal-source-format

For more details click here.

liferay-continuous-integration · 2020-06-01T18:02:19Z

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e3871929988f0958ef362c67fda0985c24454c81

ci:test:relevant - 0 out of 1 jobs PASSED

1 Failed Jobs:

~~test-portal-acceptance-pullrequest(master)~~

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)
Job Results:
0 Jobs Passed.
1 Job Failed.
The sender branch SHA could not be found on cgoncas/LPS-114284. The sender branch may have been force pushed or deleted after the pull request test was initiated.
```
fatal: Not a valid branch point: 'fc76977b2987e15afc516c32c581307744d4cc39'.
```

For upstream results, click here.

liferay-continuous-integration · 2020-06-01T22:28:59Z

✔️ ci:test:stable - 19 out of 19 jobs passed

✔️ ci:test:relevant - 42 out of 42 jobs passed in 4 hours 24 minutes

Click here for more details.

Base Branch:

Branch Name: master
Branch GIT ID: e3871929988f0958ef362c67fda0985c24454c81

Copied in Private Modules Branch:

Branch Name: master-private
Branch GIT ID: 6845814bf7a2b1b38f7c5a057c77bb287029faf4

ci:test:stable - 19 out of 19 jobs PASSED

19 Successful Jobs:

ci:test:relevant - 42 out of 42 jobs PASSED

42 Successful Jobs:

For more details click here.

liferay-continuous-integration · 2020-06-01T22:29:13Z

All required test suite(s) passed.
Forwarding pullrequest to brianchandotcom.

liferay-continuous-integration · 2020-06-01T22:29:28Z

Pull request has been successfully forwarded to brianchandotcom#89465

liferay-continuous-integration · 2020-06-02T03:36:35Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#3586
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:cgoncas#506
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:test-1-18/test-portal-acceptance-pullrequest(master)/3586 - 2020-06-01[07:51:47]
Spira Jenkins Build:publish-spira-report#372

liferay-continuous-integration · 2020-06-02T12:18:49Z

Jenkins Build:test-portal-acceptance-pullrequest(master)#7019
Jenkins Report:jenkins-report.html
Jenkins Suite: relevant
Pull Request:cgoncas#506
Spira Release:/Liferay DXP 7.3/Pull Request/ci:test:relevant
Spira Release Build:test-1-11/test-portal-acceptance-pullrequest(master)/7019 - 2020-06-01[11:04:33]
Spira Jenkins Build:publish-spira-report#728

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:sf - pending labels Jun 1, 2020

cgoncas mentioned this pull request Jun 1, 2020

LPS-114284 Add Search Container to Content Dashboard brianchandotcom/liferay-portal#89438

Closed

liferay-continuous-integration added ci:test:sf - success and removed ci:test:sf - pending labels Jun 1, 2020

cgoncas changed the title ~~LPS-114284 We don't need the EmptyOnClickRowChecker.~~ LPS-114284 Sort constructor params and minor SF changes Jun 1, 2020

liferay-continuous-integration added ci:test:relevant - failure ci:test:stable - success and removed ci:test:relevant - pending ci:test:stable - pending labels Jun 1, 2020

cgoncas added 4 commits June 1, 2020 19:29

LPS-114284 Sort contructor and make it private.

9bd4974

LPS-114284 Our tracker key is a String, so we need to class the metho…

6e18194

…d getGenericClassName.

LPS-114284 Move to DisplayContext.

ce66dc7

LPS-114284 We don't need the EmptyOnClickRowChecker.

d4e4800

cgoncas force-pushed the LPS-114284 branch from fc76977 to d4e4800 Compare June 1, 2020 17:29

liferay-continuous-integration added ci:test:sf - pending ci:test:sf - success and removed ci:test:sf - success ci:test:sf - pending labels Jun 1, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - failure and removed ci:test:relevant - failure ci:test:stable - success ci:test:relevant - pending labels Jun 1, 2020

liferay-continuous-integration added ci:test:relevant - pending ci:test:stable - pending ci:test:relevant - success ci:test:stable - success and removed ci:test:relevant - failure ci:test:stable - pending ci:test:relevant - pending labels Jun 1, 2020

liferay-continuous-integration mentioned this pull request Jun 1, 2020

LPS-114284 Sort constructor params and minor SF changes brianchandotcom/liferay-portal#89465

Closed

liferay-continuous-integration closed this Jun 1, 2020

cgoncas deleted the LPS-114284 branch June 11, 2020 07:11

LPS-114284 Sort constructor params and minor SF changes #506

LPS-114284 Sort constructor params and minor SF changes #506

Conversation

cgoncas commented Jun 1, 2020

liferay-continuous-integration commented Jun 1, 2020

cgoncas commented Jun 1, 2020

liferay-continuous-integration commented Jun 1, 2020

liferay-continuous-integration commented Jun 1, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 14 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jun 1, 2020

✔️ ci:test:stable - 19 out of 19 jobs passed

❌ ci:test:relevant - 112 out of 115 jobs passed in 2 hours 12 minutes

Base Branch:

Copied in Private Modules Branch:

3 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/3

Job Results:

test-portal-acceptance-pullrequest-batch(master)/functional-tomcat90-mysql57-jdk8/43

Job Results:

For upstream results, click here.

cgoncas commented Jun 1, 2020

cgoncas commented Jun 1, 2020

cgoncas commented Jun 1, 2020

liferay-continuous-integration commented Jun 1, 2020

liferay-continuous-integration commented Jun 1, 2020

✔️ ci:test:sf - 1 out of 1 jobs passed in 5 minutes

Base Branch:

Sender Branch:

For more details click here.

liferay-continuous-integration commented Jun 1, 2020

❌ ci:test:relevant - 0 out of 1 jobs passed in 2 minutes

Base Branch:

1 Failed Jobs:

For more details click here.

Failures unique to this pull:

test-portal-acceptance-pullrequest(master)

Job Results:

For upstream results, click here.

liferay-continuous-integration commented Jun 1, 2020

✔️ ci:test:stable - 19 out of 19 jobs passed

✔️ ci:test:relevant - 42 out of 42 jobs passed in 4 hours 24 minutes

Base Branch:

Copied in Private Modules Branch:

For more details click here.

liferay-continuous-integration commented Jun 1, 2020

liferay-continuous-integration commented Jun 1, 2020

liferay-continuous-integration commented Jun 2, 2020

liferay-continuous-integration commented Jun 2, 2020