New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CpG informative sites as index in PAMESdata #7
Comments
You are right, maybe it's better to include both indexes and probe names or probe names only. The latter case presents a problem if a beta table has no probe names associated but it would avoid a selection of wrong sites |
Great! A momentary solution could be to check for the expected dimension of the input beta matrix. This would require minimal effort and return an error if the output doesn't match the expected probe set dimension, probably avoiding the situation in most of the cases |
I won't close the issue for now, let's see how the temporary solution plays out. |
Hi, I'm trying out PAMES for the first time to calculate tumor purity for some 450k array data. It seems like the tumor_table needs to be exactly the same number of rows as the ref_table, is that correct? Are there any workarounds for cases where tumor_table may be missing data? |
Hi @jtlow, thanks for using our package! First of all, a simple workaround is to pass the same object (a matrix of beta-values coverted to percentage) to both the For sparce missing data or even entire rows/CpG sites missing, you don't need to worry, the purity will be computed anyway as long as your table has the classic Illumina 450k format. |
New version uses probe names instead of indexes |
I noticed that PAMES sites in PAMESdata collection (450k sites) are indicated as indexes rather than probe names. That might cause troubles with
compute_purity()
if those sites are used with a Beta table that is not exactly as expected by the function (indexes matching the proper probe).Ex. if a Beta table is smaller or larger, indexes will use the wrong sites. I hope this makes sense to you, what scared me the most is that when this problem happens PAMES returns no error at all, but of course, the purity estimation at that point is wrong (using wrong sites).
Please let me know if I can help by any means, this is not urgent but I think you might want to address that in the future.
The text was updated successfully, but these errors were encountered: