Show tab-line when tab-line-mode is enabled

[mitch-kyle]

No description provided.

[sarg]

Confirming that it works for me fine.
@medranocalvo have you tried it? Seems like a good addition, as exwm supports tab-bar-mode, mode-line, but not tab-line.

[medranocalvo]

Hello @mitch-kyle.

Let's start with the apologies: sorry for the long wait.

I had a look at the change and it looks good. I think I'd prefer both commits to be merged, but I can take care of that and the commit message if that's OK for you.

I couldn't find your copyright assignment. EXWM is part of GNU Emacs; as a consequence, contributions must have their copyright assigned to the FSF. Have you already assigned copyright? Otherwise, are you familiar with this matter?

@sarg, thank you for testing this change.

[mitch-kyle]

Oh no problem, do what you have to do. 👍

I've heard of the assignment process, I can see about getting that done in the next few days

[medranocalvo]

Wonderful, thank you. Have a look at https://www.gnu.org/software/emacs/manual/html_node/emacs/Copyright-Assignment.html for info regarding copyright assignment.

[walseb]

Thanks for your work on this issue!

Any update on this? I ran into this problem today.

[walseb]

@mitch-kyle ping :)

[mitch-kyle]

I don't have a working printer or scanner to fulfill gnu's archaic business processes and it's not worth it to me at this point. I wrote this freely for this project. Use it or don't.

[mitch-kyle]

Reopened to be merged whenever appropriate

[minad]

@mitch-kyle This has already been discussed and sorry for bringing it up again - do you have the chance and are you willing to sign the FSF copyright papers? In my case, the whole process was rather smooth and went completely via email. I don't recall, either I signed via a wacom display or I copied my signature as an image into the form. The whole process didn't take too long. But I understand that it is demotivating that this has to be done before your change can be merged.

[medranocalvo]

@minad, @mitch-kyle has assigned copyright, we have to wait for confirmation. Sorry, I should have written this earlier.

I think we should release 0.29 with current changes and after that merge XSETTINGS and tab-line, and leave both some time on master. But first let's move to the org so that I don't block anymore.

@mitch-kyle: thank you very much, double thanks for your work and your willingness to help.

[minad]

@mitch-kyle @medranocalvo Thank you both! @Stebalien and I will handle this PR after the migration.

[minad]

@medranocalvo @Stebalien I think a 0.29 release is not needed right now given the small number of changes since 0.28. I prefer if we don't block additions like xsettings if they have to be enabled explicitly anyway. I haven't tried/checked this tab-line patch yet, but it might also be simple enough to get in now.

[medranocalvo]

@medranocalvo @Stebalien I think a 0.29 release is not needed right now given the small number of changes since 0.28. I prefer if we don't block additions like xsettings if they have to be enabled explicitly anyway. I haven't tried/checked this tab-line patch yet, but it might also be simple enough to get in now.

Oh, that's definitely alright. We can merge @mitch-kyle's patch as well, but then shouldn't release until we have confirmation that the papers got through. I've asked Stefan Monnier to check, will post once we have confirmation.

[medranocalvo]

Not yet filed. I'll ask again in a week or two.

[medranocalvo]

Not yet filed. I'll ask again in a week or two.

Not yet on file. I'll ask again in a week or two.