Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from glimmer.js to svelte #19

Merged
merged 81 commits into from
Oct 12, 2022
Merged

Migrate from glimmer.js to svelte #19

merged 81 commits into from
Oct 12, 2022

Commits on Sep 7, 2022

  1. Bump bestzip from 1.1.4 to 2.1.7 in /chrome

    Bumps [bestzip](https://github.com/nfriedly/node-bestzip) from 1.1.4 to 2.1.7.
    - [Release notes](https://github.com/nfriedly/node-bestzip/releases)
    - [Commits](nfriedly/node-bestzip@v1.1.4...v2.1.7)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    f9d7d8c View commit details
    Browse the repository at this point in the history
  2. Initial svelte commit

    chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c7941c9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0a93461 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f804236 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7b34a2d View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fa34120 View commit details
    Browse the repository at this point in the history
  7. Migrate storage and store

    chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    5b1dfdf View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e3858c3 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    364e66a View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7807471 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    fa4bef5 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    673ca5d View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    43cc869 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    3a0eeec View commit details
    Browse the repository at this point in the history
  15. Fix ssr issues with window

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6440579 View commit details
    Browse the repository at this point in the history
  16. Update svelte deps

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d104fd0 View commit details
    Browse the repository at this point in the history
  17. Modernize sveltekit and deps

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    df0b34c View commit details
    Browse the repository at this point in the history
  18. Wire up Settinigs page and route transitions

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c5eb490 View commit details
    Browse the repository at this point in the history
  19. Tabs -> 2 spaces

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    31be314 View commit details
    Browse the repository at this point in the history
  20. Add CountdownMessage component

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    82732c0 View commit details
    Browse the repository at this point in the history
  21. Add SettingsButton with gear icon

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    19ec760 View commit details
    Browse the repository at this point in the history
  22. Remove some dead styles from the Settings component

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    629c2b9 View commit details
    Browse the repository at this point in the history
  23. Set date value settings on blur

    This helps fix the issue with the zero padding (2 -> 02) occuring
    while typing, and instead allow it to happen after an input
    is considered settled
    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fbbbea8 View commit details
    Browse the repository at this point in the history
  24. Fix handling around async loading settings store

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    e520e04 View commit details
    Browse the repository at this point in the history
  25. Speed up animation timings

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    a730ea7 View commit details
    Browse the repository at this point in the history
  26. Remove unneeded root Vorfreude component

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    2958fe6 View commit details
    Browse the repository at this point in the history
  27. Move data manipulation outside of Settings component

    The settings page gets the initial settings and passes along with
    handlers for on submission and on close.
    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    86af8de View commit details
    Browse the repository at this point in the history
  28. More timing tweaks

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4466c37 View commit details
    Browse the repository at this point in the history
  29. Setup testing to work with slots

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    cf38716 View commit details
    Browse the repository at this point in the history
  30. Add Button component test

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    f8aeec7 View commit details
    Browse the repository at this point in the history
  31. Add @babel/preset-typescript for testing with typescript

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8201489 View commit details
    Browse the repository at this point in the history
  32. Update Settings test with inline precompile

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    67ec4bd View commit details
    Browse the repository at this point in the history
  33. Add @testing-library/user-event

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    dcd8662 View commit details
    Browse the repository at this point in the history
  34. Fix string indentation

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    571c0f0 View commit details
    Browse the repository at this point in the history
  35. Refactor and improve Settings component tests

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8e89218 View commit details
    Browse the repository at this point in the history
  36. Fix up CountdownMessage and has-date-past utility

    Add tests and fix luxon `diffNow` usage with has-date-past
    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    017f9ea View commit details
    Browse the repository at this point in the history
  37. Add testing with github actions

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    fe27f59 View commit details
    Browse the repository at this point in the history
  38. Fix tsconfig.json based on ci error requiring extends

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6f425df View commit details
    Browse the repository at this point in the history
  39. Fix playwright acceptance tests to run explicitly on port 3000

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    0447d9c View commit details
    Browse the repository at this point in the history
  40. Sync .svelte-kit (contains tsconfig) in github actions ci

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b4aaec5 View commit details
    Browse the repository at this point in the history
  41. Run browser install command for playwright in github actions ci

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    b057251 View commit details
    Browse the repository at this point in the history
  42. Add static asset icons and update app.html

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    d00f7ff View commit details
    Browse the repository at this point in the history
  43. Add basic acceptance test

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    4cbc11a View commit details
    Browse the repository at this point in the history
  44. Add additional acceptance tests

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    8b5efb3 View commit details
    Browse the repository at this point in the history
  45. Update project README

    Chad Carbert authored and chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    9919d13 View commit details
    Browse the repository at this point in the history
  46. Configuration menu
    Copy the full SHA
    5182c90 View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    2b11b66 View commit details
    Browse the repository at this point in the history
  48. Avoid initial photo load

    By loading a photo and then getting the settings on subscription
    creates a double-load and a flickr.
    chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    6595e53 View commit details
    Browse the repository at this point in the history
  49. Configuration menu
    Copy the full SHA
    5c626f1 View commit details
    Browse the repository at this point in the history
  50. Tweak animation timings

    chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    687aacb View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    97baf9a View commit details
    Browse the repository at this point in the history
  52. Add missing ramda dependency

    chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    1bfbb8e View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    52d0630 View commit details
    Browse the repository at this point in the history
  54. Configuration menu
    Copy the full SHA
    deec15d View commit details
    Browse the repository at this point in the history
  55. Configuration menu
    Copy the full SHA
    3a7f6c5 View commit details
    Browse the repository at this point in the history
  56. Tweak Wallpaper component

    * Ensure image is fully loaded before showing wallpaper
    * Use vw and vh units instead of 100% for width and height
    * Use object-fit with img tag instead of background-image with div
    chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    bbbc0cd View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    b0b87f4 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    e66633d View commit details
    Browse the repository at this point in the history
  59. Run prettier

    * change prettierrc to use spaces instead of tabs
    chadian committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    c44e910 View commit details
    Browse the repository at this point in the history
  60. Configuration menu
    Copy the full SHA
    b30a309 View commit details
    Browse the repository at this point in the history
  61. Configuration menu
    Copy the full SHA
    6e17f2c View commit details
    Browse the repository at this point in the history
  62. Configuration menu
    Copy the full SHA
    a7391bb View commit details
    Browse the repository at this point in the history
  63. Configuration menu
    Copy the full SHA
    29e3f10 View commit details
    Browse the repository at this point in the history
  64. Configuration menu
    Copy the full SHA
    257787a View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    179a795 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5d6c33a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4da52cf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a880044 View commit details
    Browse the repository at this point in the history
  5. Use hacky hash routing

    Using hashes to track routes in urls is better for chrome
    extensions. This is because the default of providing a route at
    /settings for example doesn't map in extension land to a .html
    
    There is probably a way of intercepting route changes in
    extensions for urls and redirecting them but this would require
    escalated privledges and be harder to test.
    
    The other method of generating a prerendered .html file for every
    route almost worked except svelte's routing doesn't recognize
    a route at its .html location once it's loaded. It wants to deal
    with goto("/settings"), it doesn't recognize
    goto("/settings.html").
    
    The hacky workaround I have here works pretty well. Every route
    change that happens it goes and replaces the current route with
    a corresponding hash representation.
    
    If someone reloads the page the hash representation needs to be
    mapped back to its corresponding route and then navigated to
    that route by svelte's `goto`. Upon entering that route it will
    again have its url replaced with its hash match.
    
    This method also helps encapsulate the swapping of the routes
    to be friendly for local dev server or extension. In the case of
    the extension the hash is at "index.html#route" and when being
    served by the local dev server it is replaced with "/#route".
    
    While this is hacky it is consistent and allows for everything
    to be handled entirely "in app". If this app were to increase the
    number of routes it had to manage then this hash mapping would
    become less sustainable and maybe more research into how other
    svelte apps handle this challenge would be warranted.
    chadian committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    1ad208f View commit details
    Browse the repository at this point in the history
  6. Use dedicated settings.html page to redirect to index.html#settings

    If there was already a chrome tab opened then going to the options
    would not open a new tab at #settings nor would it update the
    existing opened tab to #settings, resulting in the options button
    linked from the browser's extension page essentially noop'ing.
    
    This dedicated settings.html does a local js redirect to
    index.html#settings and that way every new tab opened by the
    browser's extension option page will end up at index.html#settings
    chadian committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    f20bdf7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7b066cc View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bf0b83a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    0e9d843 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    a982498 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    7c89c81 View commit details
    Browse the repository at this point in the history
  12. Bump all the dependencies

    chadian committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    643c567 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    ea6ae39 View commit details
    Browse the repository at this point in the history
  14. Set background image to fallback gradient in app.html

    This means that the bg will be rendered before any js and css is
    loaded and parsed, hopefully reducing the amount of "white" flash
    chadian committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    36db2fe View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Configuration menu
    Copy the full SHA
    088add1 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2022

  1. Add hacky index.html route

    This commit adds a route that is as an ugly hack for when
    "index.html" loads and it tries to load the corresponding route.
    Without this "index.html" route the router can't find a matching
    route, throws an error, but still ends up at the default route
    (so the user doesn't notice the issue) but it leaves an ugly
    error in the console.
    
    By having an "index.html" route which is a shortcoming of being
    able to serve from static files like within extensions, this
    route kicks things off by navigating to the root route "/".
    chadian committed Sep 11, 2022
    Configuration menu
    Copy the full SHA
    9a461fd View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2022

  1. Configuration menu
    Copy the full SHA
    8fbfda1 View commit details
    Browse the repository at this point in the history