Use chainner_ext for Fill Alpha
#1865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I already shared the improved performance on Discord, but I changed the settings a little since. The Rust implementation of
fill_alpha_extend_coloris around 100x faster than the Python implementation (not counting the overhead of copying a numpy image to Rust), so I increased the number of iterations to fill the whole image. The performance cost for this is relatively small even for large images. Even with the new settings, Extend Texture is around 5x faster and Extend Color is around 15x faster.Obviously, this PR also adds
chainner_extas a dependency. I only published v0.0.0 (a test version) right now. Before we includechainner_extin the next release, we have to make sure that it works correctly for our users. I published pre-built wheels for all major architectures and python versions (3.8-3.11), but I haven't tested anything except cp3.8 Win x64 and cp3.9 Win x64 yet.