Add "Get Bounding Box" node #1884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts part of commit 0e3ab2a.
backend/src/packages/chaiNNer_standard/image_dimension/utility/get_bounding_box.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/image_dimension/utility/get_bounding_box.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/image_dimension/utility/get_bounding_box.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/image_dimension/utility/get_bounding_box.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/image_dimension/utility/get_bounding_box.py
Outdated
Show resolved
Hide resolved
backend/src/packages/chaiNNer_standard/image_dimension/utility/get_bounding_box.py
Outdated
Show resolved
Hide resolved
- changed the minimum and default to 0, and explicitly set a maximum - renamed the function - added output_types to the outputs
The output type for width and height is also more explicit.
if there are no rows in the threshold, then there can't be any columns.
RunDevelopment
approved these changes
Jun 23, 2023
There was a problem hiding this comment.
I finally tested it, and it works well. Thank you @zeptofine!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially does the same thing as the 'crop content' node but instead returns the dimensions needed to do such an operation.
The threshold represents the minimum value a pixel must be to be considered part of the mask.
This example uses the data to simply crop the original image, like 'crop content':
Having these as separate node operations give access to more complex node setups, like this version:
This crops the image, superscales the specific section then moves it back into place.
Edit: changed the complex example to use the mask as transparency.