Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Get Bounding Box" node #1884

Merged
merged 8 commits into from
Jun 23, 2023
Merged

Add "Get Bounding Box" node #1884

merged 8 commits into from
Jun 23, 2023

Commits on Jun 22, 2023

  1. add bounding box node

    @zeptofine
    zeptofine committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0ee17bf View commit details
    Browse the repository at this point in the history

  2. remove unncessary imports

    @zeptofine
    zeptofine committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    891c907 View commit details
    Browse the repository at this point in the history

  3. edit the description

    @zeptofine
    zeptofine committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0e3ab2a View commit details
    Browse the repository at this point in the history

  4. Revert parts of "edit the description" 

    This reverts part of commit 0e3ab2a.
    @zeptofine
    zeptofine committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    9f29977 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. fixes from suggestions 

    - changed the minimum and default to 0, and explicitly set a maximum
- renamed the function
- added output_types to the outputs
    @zeptofine
    zeptofine committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b9f260c View commit details
    Browse the repository at this point in the history

  2. update icon to BsBoundingBox

    @zeptofine
    zeptofine committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ff46dc5 View commit details
    Browse the repository at this point in the history

  3. Raise error when the bounding box is empty 

    The output type for width and height is also more explicit.
    @zeptofine
    zeptofine committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    e013040 View commit details
    Browse the repository at this point in the history

  4. small logic simplification 

    if there are no rows in the threshold, then there can't be any columns.
    @zeptofine
    zeptofine committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    ff3b32f View commit details
    Browse the repository at this point in the history