More macOS bugfixes/enhancements #2049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyballentine
approved these changes
Aug 3, 2023
|
Joey already merged, but I'll tell you about anyway. The chaiNNer/src/main/gui/create.ts Line 82 in fbd9480 |
|
Oh, oops |
|
@RunDevelopment Yeah, didn't see. Not that familiar with the codebase yet. Someone should remove L81-86 from |
Will do. |
stonerl
pushed a commit
to stonerl/chaiNNer
that referenced
this pull request
Aug 3, 2023
* quit out of app on macOS once all windows are closed * enable mps fallback on apple silicon * move mps fallback somewhere else * lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After closing the window on macOS, the app just stays in the dock & you can click it but it won't reopen. It will call
app.quit()now once all window instances are closed.SwinIR throws an error with the mps backend, because the aten::roll operator isn't implemented for mps yet.
I've set the environment variable to fall back to CPU on unsupported operators. This fixes the error & allows running SwinIR on the GPU, instead of fully on the CPU and brings a performance improvement of 3x.