Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visually show feature-disabled nodes as disabled #2194

Merged
merged 2 commits into from
Sep 10, 2023

Conversation

joeyballentine
Copy link
Member

@joeyballentine joeyballentine commented Sep 8, 2023

when a feature is unavailable:

  • lower the opacity to 50%
  • prevent drag & dropping the node

thoughts: we probably need to also filter out these nodes from the context menu selector, as well as maybe indicate in the docs that they are unavailable.

@RunDevelopment
Copy link
Member

  1. Presenting an error in exactly the same way we normally present node descriptions is not a good idea. How about we show the node description + "\n\nThis node is currently disabled because the feature is not enabled."
    image
  2. "prevent drag & dropping the node" Is that actually a good idea? What if you don't have a feature enabled, but want to create a chain for a friend that does?

@joeyballentine joeyballentine merged commit 76c0c6f into main Sep 10, 2023
4 checks passed
@joeyballentine joeyballentine deleted the show-feature-disable branch September 10, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants