Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visually show feature-disabled nodes as disabled #2194

Merged
merged 2 commits into from
Sep 10, 2023
Merged

Visually show feature-disabled nodes as disabled #2194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9c8580
Visually show feature-disabled nodes as disabled
joeyballentine Sep 8, 2023
0f61100
PR Suggestions
joeyballentine Sep 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 27 additions & 2 deletions src/renderer/components/NodeSelectorPanel/RepresentativeNodeWrapper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { BsFillJournalBookmarkFill } from 'react-icons/bs';
import { useReactFlow } from 'reactflow';
import { useContext } from 'use-context-selector';
import { NodeSchema } from '../../../common/common-types';
import { BackendContext } from '../../contexts/BackendContext';
import { GlobalContext } from '../../contexts/GlobalNodeState';
import { NodeDocumentationContext } from '../../contexts/NodeDocumentationContext';
import { ChainnerDragData, TransferTypes } from '../../helpers/dataTransfer';
Expand All @@ -16,14 +17,21 @@ import { RepresentativeNode } from './RepresentativeNode';
interface TooltipLabelProps {
name?: string;
description: string;
unavailableReason?: string;
}
const TooltipLabel = memo(({ name, description }: TooltipLabelProps) => {
const TooltipLabel = memo(({ name, description, unavailableReason }: TooltipLabelProps) => {
const firstParagraph = description.split('\n\n')[0];

let text = firstParagraph;

if (unavailableReason) {
text += `\n\nThis node is currently unavailable because a feature is not enabled. Reason(s):\n\n${unavailableReason}`;
}

return (
<>
{name && <Text fontWeight="bold">{name}</Text>}
<Markdown nonInteractive>{firstParagraph}</Markdown>
<Markdown nonInteractive>{text}</Markdown>
</>
);
});
Expand All @@ -48,6 +56,7 @@ interface RepresentativeNodeWrapperProps {
export const RepresentativeNodeWrapper = memo(
({ node, collapsed = false }: RepresentativeNodeWrapperProps) => {
const { reactFlowWrapper, setHoveredNode, createNode } = useContext(GlobalContext);
const { featureStates } = useContext(BackendContext);
const reactFlowInstance = useReactFlow();
const { openNodeDocumentation } = useContext(NodeDocumentationContext);

Expand Down Expand Up @@ -110,6 +119,20 @@ export const RepresentativeNodeWrapper = memo(
});
}, [createNode, node.schemaId, node.nodeType, reactFlowInstance, reactFlowWrapper]);

const featureDetails = node.features.map((feature) => {
const featureState = featureStates.get(feature);
return { isEnabled: featureState?.enabled, details: featureState?.details };
});

const isDisabled = featureDetails.some((feature) => !feature.isEnabled);

const unavailableReason = isDisabled
? featureDetails
.filter((feature) => !feature.isEnabled)
.map((feature) => feature.details)
.join('\n')
: undefined;

return (
<Box
my={1.5}
Expand All @@ -135,6 +158,7 @@ export const RepresentativeNodeWrapper = memo(
<TooltipLabel
description={node.description}
name={collapsed ? node.name : undefined}
unavailableReason={unavailableReason}
/>
}
openDelay={500}
Expand All @@ -146,6 +170,7 @@ export const RepresentativeNodeWrapper = memo(
draggable
boxSizing="content-box"
display="block"
opacity={isDisabled ? 0.5 : 1}
onClick={() => {
setDidSingleClick(true);
}}
Expand Down