Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add open delay to status tooltips #2364

Merged
merged 1 commit into from
Dec 2, 2023
Merged

Add open delay to status tooltips #2364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/renderer/components/node/NodeFooter/Timer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ export const Timer = memo(({ time }: TimerProps) => {
closeOnClick={false}
gutter={24}
label={`Execution took approximately ${joinEnglish(longParts)}.`}
openDelay={150}
px={2}
textAlign="center"
>
Expand Down
107 changes: 45 additions & 62 deletions src/renderer/components/node/NodeFooter/ValidityIndicator.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,80 +15,63 @@ interface ValidityIndicatorProps {
export const ValidityIndicator = memo(({ validity, animated }: ValidityIndicatorProps) => {
const { paused } = useContext(ExecutionStatusContext);

// eslint-disable-next-line no-nested-ternary
return animated ? (
paused ? (
<Tooltip
hasArrow
borderRadius={8}
closeOnClick={false}
gutter={24}
label="This node is currently paused"
px={2}
textAlign="center"
>
<Center className="nodrag">
<Center
bgColor="var(--node-valid-bg)"
borderRadius={100}
h="auto"
w="auto"
>
<Icon
as={IoIosPause}
boxSize="1rem"
color="var(--node-valid-fg)"
cursor="default"
m="auto"
/>
</Center>
</Center>
</Tooltip>
) : (
<Tooltip
hasArrow
borderRadius={8}
closeOnClick={false}
gutter={24}
label="This node is currently running..."
px={2}
textAlign="center"
>
<Center className="nodrag">
<Spinner size="xs" />
</Center>
</Tooltip>
)
) : (
<Tooltip
hasArrow
borderRadius={8}
closeOnClick={false}
gutter={24}
label={
<Markdown nonInteractive>
{validity.isValid ? 'Node valid' : validity.reason}
</Markdown>
}
px={2}
textAlign="center"
>
<Center className="nodrag">
let icon;
let text;
if (animated) {
if (paused) {
text = 'This node is currently paused';
icon = (
<Center
bgColor={validity.isValid ? 'var(--node-valid-bg)' : 'var(--node-invalid-bg)'}
bgColor="var(--node-valid-bg)"
borderRadius={100}
h="auto"
w="auto"
>
<Icon
as={validity.isValid ? BsCheck : BsExclamation}
as={IoIosPause}
boxSize="1rem"
color={validity.isValid ? 'var(--node-valid-fg)' : 'var(--node-invalid-fg)'}
color="var(--node-valid-fg)"
cursor="default"
m="auto"
/>
</Center>
);
} else {
text = 'This node is currently running...';
icon = <Spinner size="xs" />;
}
} else {
text = validity.isValid ? 'Node valid' : validity.reason;
icon = (
<Center
bgColor={validity.isValid ? 'var(--node-valid-bg)' : 'var(--node-invalid-bg)'}
borderRadius={100}
h="auto"
w="auto"
>
<Icon
as={validity.isValid ? BsCheck : BsExclamation}
boxSize="1rem"
color={validity.isValid ? 'var(--node-valid-fg)' : 'var(--node-invalid-fg)'}
cursor="default"
m="auto"
/>
</Center>
);
}

return (
<Tooltip
hasArrow
borderRadius={8}
closeOnClick={false}
gutter={24}
label={<Markdown nonInteractive>{text}</Markdown>}
openDelay={150}
px={2}
textAlign="center"
>
<Center className="nodrag">{icon}</Center>
</Tooltip>
);
});