More compact collapsed node design #2551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this a lot. The only thing I'm not a fan of is when it overflows (like what you sent in the other PR). I'm wondering if we can come up with a good solution for that |
|
Ugly tall nodes:
Not a nice design, but it works. |
|
I'd be interested in seeing something proposed with the connection density on the side of the nodes compressing as shown but with the height of the collapsed node limited something to something that is a max 1.5x factor of a "plain" collapsed node such as the TEXT node on the left of the above image. |
|
@mrjschulte So you're suggesting changing the size of the handles instead? I could try that out, but first I'm gonna merge this |
joeyballentine
approved these changes
Feb 7, 2024
joeyballentine
added a commit
that referenced
this pull request
Feb 8, 2024
* Collapse nodes implementation * styling tweak * Save data properly * nodrag on button * each item in list must have unique key prop * change collapse button bg to transparent * Fix documentation node example * double click to collapse * More compact collapsed node design (#2551) * More compact collapsed node design * Fixed type error * Remove placeholder icon * Ugly tall nodes * change caret directions * Support collapsing in node docs * Fix input type colors in collapsed node * "each item in list must have unique key prop" * Update src/renderer/components/node/Node.tsx Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com> * dont show collapse button if useCollapse not passed in (for docs) * Update src/renderer/components/Handle.tsx Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com> * dont do the dumb thing * Extract into hook --------- Co-authored-by: Michael Schmidt <mitchi5000.ms@googlemail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the design for collapsed nodes that I mentioned.